-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[River] Responsive spacing #236
Conversation
🦋 Changeset detectedLatest commit: 9736c9c The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🔍 Design token changes foundView CSS variable changes- --brand-River-layout-margin-vertical: var(--base-size-48) 0;
+ --brand-River-heading-margin: var(--base-size-8); |
26b5f97
to
df1c1ce
Compare
🟢 No visual differences foundOur visual comparison tests did not find any differences in the UI. |
96dbb4a
to
4705df7
Compare
packages/design-tokens/src/tokens/functional/components/river/base.json
Outdated
Show resolved
Hide resolved
packages/design-tokens/src/tokens/functional/components/river/base.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New spacing looks great 👍
Summary
New and updated spacing tokens on the
River
component aiming for a responsive logic in bothgap
andpadding
values of the main containerNew padding values are:
28px
-> total of56px
when used stacked36px
-> total of72px
when used stacked48px
-> total of96px
when used stackedNew gap values are:
24px
32px
48px
List of notable changes:
margin
forsmall/medium/large-padding
tokengap
forsmall/medium/large-gap
tokenWhat should reviewers focus on?
Steps to test:
Supporting resources (related issues, external links, etc):
Contributor checklist:
Reviewer checklist:
Screenshots:
actual.mp4
new.mp4