Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IE9 hacks for the select's background image/padding? #610

Closed
jdanyow opened this issue Nov 22, 2018 · 1 comment
Closed

Remove IE9 hacks for the select's background image/padding? #610

jdanyow opened this issue Nov 22, 2018 · 1 comment

Comments

@jdanyow
Copy link
Contributor

jdanyow commented Nov 22, 2018

Would the team accept a PR to undo #144? Reason I ask is the hacks cause problems with minified css. Here's a page exhibiting the problem (form-select is under the theme heading).

https://github.com/primer/primer/blob/ab720451c2e7e2ac4dfc7c208879b20ac2dbacc5/modules/primer-forms/lib/form-select.scss#L8-L10

@shawnbot
Copy link
Contributor

Thanks for the heads up, @jdanyow. We don't support IE9 anymore, so as far as I'm concerned all of those hacks can go. Pull requests are certainly welcome! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants