Adios purple buttons #736
Merged
Adios purple buttons #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Technically this is a breaking change because it removes styles. We're going to have to hold off on this until #730 and we can prep a release for 13.0.0. |
simurai
moved this from Release backlog
to Needs review
in 📦 Primer CSS release tracking
shawnbot
moved this from Needs review
to Release backlog
in 📦 Primer CSS release tracking
|
Just documenting that we're also removing |
shawnbot
added a commit
that referenced
this pull request
Jun 3, 2019
shawnbot
moved this from Release backlog
to Ready to release
in 📦 Primer CSS release tracking
|
👋😭 |
added 2 commits
September 9, 2019 14:31
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://primer-css-git-adios-purp.primer.now.sh |
This was referenced Sep 9, 2019
Merged
This was referenced Dec 13, 2022
This was referenced Dec 25, 2022
This was referenced Jan 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the purple buttons from primer and mentions of them in the docs.
It solves the first half of #734. Turns out there aren't any orange buttons in Primer.
I'll follow up with a PR removing blue buttons once we've removed them from
github/github./cc @primer/ds-core