Create Blankslate Documentation #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilybrick
reviewed
Aug 7, 2019
emilybrick
reviewed
Aug 7, 2019
Co-Authored-By: Emily Brick <emilybrick@github.com>
Co-Authored-By: Emily Brick <emilybrick@github.com>
ashygee
previously requested changes
Aug 7, 2019
Co-Authored-By: Ash Guillaume <10384315+ashygee@users.noreply.github.com>
Co-Authored-By: Ash Guillaume <10384315+ashygee@users.noreply.github.com>
Co-Authored-By: Ash Guillaume <10384315+ashygee@users.noreply.github.com>
Co-Authored-By: Ash Guillaume <10384315+ashygee@users.noreply.github.com>
Co-Authored-By: Ash Guillaume <10384315+ashygee@users.noreply.github.com>
Co-Authored-By: Ash Guillaume <10384315+ashygee@users.noreply.github.com>
Co-Authored-By: Ash Guillaume <10384315+ashygee@users.noreply.github.com>
Co-Authored-By: Ash Guillaume <10384315+ashygee@users.noreply.github.com>
Co-Authored-By: Ash Guillaume <10384315+ashygee@users.noreply.github.com>
Co-Authored-By: Ash Guillaume <10384315+ashygee@users.noreply.github.com>
Co-Authored-By: Ash Guillaume <10384315+ashygee@users.noreply.github.com>
…design into blankslate-documentation
zainkho
dismissed
ashygee’s stale review
Spoke IRL and will discuss primary actions at design review. Shipping guidelines as is for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds documentation for the Primer Blankslate component. Initial ship contains new blankslate components for pictograms and illustrations as well as 2-3 line variations for each.
These components look like:
Pictograms
Illustrations
The documentation also contains guidelines for copy for each aspect of the component.
I'm open to feedback on content of the documentation and if there's anything else we need to include. Thanks for y'alls help 🤠