Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default background-color to SideNav #873

Merged
merged 1 commit into from
Aug 27, 2019
Merged

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Aug 26, 2019

This adds a default background-color to the .SideNav component.

Reasoning

The main reason is to make the linter pass. 😇 Currently in our documentation we have:

<nav class="SideNav bg-gray-light border">
  <a class="SideNav-item">
  <a class="SideNav-item">

But that causes an The following CSS classes were used in class attributes but have no style rules referencing them error when used on .com. We could remove SideNav from the markup, but that feels very strange, not having a "main" class name and only use child class names.

So we need "some" property that we can use (.SideNav { ??? }). Adding background-color seems to make the most sense since we typically use a light gray background for Side Navs.

@vercel
Copy link

vercel bot commented Aug 26, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://primer-css-git-sidenav-bg.primer.now.sh

@simurai simurai added this to Release backlog in 📦 Primer CSS release tracking via automation Aug 26, 2019
@simurai simurai moved this from Release backlog to Ready to release in 📦 Primer CSS release tracking Aug 26, 2019
@simurai simurai mentioned this pull request Aug 26, 2019
7 tasks
@simurai simurai changed the base branch from master to release-12.6.2 August 26, 2019 06:03
@simurai simurai requested a review from shawnbot August 26, 2019 06:55
Copy link
Contributor

@shawnbot shawnbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants