Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 12.6.2 #874

Merged
merged 9 commits into from
Aug 27, 2019
Merged

Release 12.6.2 #874

merged 9 commits into from
Aug 27, 2019

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Aug 26, 2019

Primer CSS Patch Release

Version: 📦 12.6.2
Approximate release date: 📆 Aug 27, 2019

💅 Polish

🏠 Internal


Ship checklist

  • Update the version field in package.json
  • Update CHANGELOG.md
  • Test the release candidate version with github/github
  • Merge this PR and create a new release
  • Update github/github

For more details, see RELEASING.md.

/cc @primer/ds-core

@vercel
Copy link

vercel bot commented Aug 26, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://primer-css-git-release-1262.primer.now.sh

@simurai
Copy link
Contributor Author

simurai commented Aug 26, 2019

When running npm version patch I got this error:

npm version patch
v12.6.2
npm ERR! version Bad package-lock.json data.
npm ERR! Unexpected token < in JSON at position 58172 while parsing near '...0.8"
npm ERR!       }
npm ERR!     },
npm ERR! <<<<<<< HEAD
npm ERR! =======...'

I guess it's a leftover from a merge conflict? Running npm install seemed to re-generate the package-lock.json and remove the conflicts.

Also, there were two @primer/octicons that are now reduced to just "@primer/octicons": "9.1.1".

@simurai simurai requested a review from shawnbot August 26, 2019 06:56
package.json Outdated Show resolved Hide resolved
Co-Authored-By: Shawn Allen <shawn.allen@github.com>
@vercel vercel bot temporarily deployed to staging August 27, 2019 00:44 Inactive
Add default background-color to SideNav
@vercel vercel bot temporarily deployed to staging August 27, 2019 00:45 Inactive
RELEASING.md Outdated Show resolved Hide resolved
Copy link
Contributor

@shawnbot shawnbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@shawnbot shawnbot merged commit ea68026 into master Aug 27, 2019
@shawnbot shawnbot deleted the release-12.6.2 branch August 27, 2019 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants