Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip link to allow user to skip to page content. #94

Merged
merged 2 commits into from
Nov 26, 2019
Merged

Skip link to allow user to skip to page content. #94

merged 2 commits into from
Nov 26, 2019

Conversation

dmarcey
Copy link
Contributor

@dmarcey dmarcey commented Sep 26, 2019 •
edited
Loading

Github.com:
image

Doctocat:
image

Closes #82
Saves 21 tabs to get to main content on Doctocat site!

@vercel
Copy link

vercel bot commented Sep 26, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://doctocat-git-skip-link.primer.now.sh

colebemis
colebemis approved these changes Sep 26, 2019
View reviewed changes
Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Thanks @dmarcey 💙I just left a few comments, nothing blocking though.

theme/src/components/skip-link.js Outdated Show resolved Hide resolved
theme/src/components/skip-link.js Outdated Show resolved Hide resolved
theme/src/components/skip-link.js Show resolved Hide resolved
emplums
emplums approved these changes Sep 30, 2019
View reviewed changes
Copy link
Contributor

@emplums emplums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Thanks!

@emplums emplums merged commit 33e60c9 into master Nov 26, 2019
@emplums emplums deleted the skip-link branch November 26, 2019 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colebemis colebemis colebemis approved these changes

@emplums emplums emplums approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "Skip to main content" link
3 participants
@dmarcey @colebemis @emplums