Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set terminal.tab.activeBorder based on editor tab #189

Merged
merged 1 commit into from
Aug 9, 2021
Merged

Set terminal.tab.activeBorder based on editor tab #189

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/classic/theme.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,7 @@ function getTheme({ style, name }) {
"panelInput.border": pick({ light: primer.gray[2], dark: primer.gray[1] }),

"terminal.foreground": primer.gray[6],
"terminal.tab.activeBorder": "#f9826c",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can not reproduce this change:

screenshot-Mon-19Jul21_01 15

I also can not find this attribute in the VSCode Theme Color Documentation. Is this a user setting?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in Insiders only right now, coming in the next version

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you for your contribution. can you please provide a link to the documentation for the insiders build in this PR comments so we can reference it? 🚀

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no documentation yet, here's where it's declared in code though:

https://github.com/microsoft/vscode/blob/7667e90bf82ece1395727c7d88a37114fe1488a4/src/vs/workbench/contrib/terminal/common/terminalColorRegistry.ts#L40-L44

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in Insiders only right now, coming in the next version

Thanks for clarifying. I think this should be fine to already merge. 👍


"gitDecoration.addedResourceForeground": primer.green[5],
"gitDecoration.modifiedResourceForeground": primer.blue[6],
Expand Down