Skip to content

Commit

Permalink
separate octicons.scss from sprockets-octicons.scss
Browse files Browse the repository at this point in the history
  • Loading branch information
Cameron423698 committed Jun 2, 2015
1 parent b24ada2 commit b027d2d
Show file tree
Hide file tree
Showing 7 changed files with 6 additions and 9 deletions.
Binary file modified octicons/octicons-local.ttf
Binary file not shown.
Binary file modified octicons/octicons.eot
Binary file not shown.
2 changes: 1 addition & 1 deletion octicons/octicons.less
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@octicons-font-path: ".";
@octicons-version: "d06ce002ddd442d23cd70c22b9373bd4d73fa109";
@octicons-version: "932555081d58ad24701c658c97328237bbc156d2";

@font-face {
font-family: 'octicons';
Expand Down
Binary file modified octicons/octicons.ttf
Binary file not shown.
Binary file modified octicons/octicons.woff
Binary file not shown.
11 changes: 4 additions & 7 deletions octicons/sprockets-octicons.scss
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
$octicons-font-path: "." !default;
$octicons-version: "d06ce002ddd442d23cd70c22b9373bd4d73fa109";

@font-face {
font-family: 'octicons';
src: url('#{$octicons-font-path}/octicons.eot?#iefix&v=#{$octicons-version}') format('embedded-opentype'),
url('#{$octicons-font-path}/octicons.woff?v=#{$octicons-version}') format('woff'),
url('#{$octicons-font-path}/octicons.ttf?v=#{$octicons-version}') format('truetype'),
url('#{$octicons-font-path}/octicons.svg?v=#{$octicons-version}#octicons') format('svg');
src: font-url('octicons.eot?#iefix') format('embedded-opentype'),
font-url('octicons.woff') format('woff'),
font-url('octicons.ttf') format('truetype'),
font-url('octicons.svg#octicons') format('svg');
font-weight: normal;
font-style: normal;
}
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "octicons",
"version": "2.3.0",
"version": "2.4.0",
"description": "GitHub's icon font",
"main": "README.md",
"repository": {
Expand Down

4 comments on commit b027d2d

@cameronmcefee
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wjdp It was pointed out that the changes to sprockets-octicons.scss broke Octicons in Rails (Sprockets).

This adds a dedicated octicons.scss file to support the path you added.

@wjdp
Copy link
Contributor

@wjdp wjdp commented on b027d2d Jun 2, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it did feel a bit naughty to be putting it in a file intended for sprockets as that's not my use case. However it doesn't look like you've added octicons.scss to this commit?

@cameronmcefee
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.< you are correct. Hold please…

@cameronmcefee
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated for 2.4.1 Sorry about that.

Please sign in to comment.