Monocticons: Octicons mono repository #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Jekyll::Octicons` is shadows the global `Octicons` constant.
Add tests for tag parsing and rendering
Before:
{% octicon :symbol => "alert", :size => "large", :class => "right left", :'aria-label' => "hi" %}
After:
{% octicon alert size:large class:"right left" aria-label:hi %}
Update syntax to use liquid-style attributes
Adding interpolation of variables
Updating plugin to use octicons@2.0.0
This reverts commit 67e4a54.
dmitshur
reviewed
Feb 12, 2018
| @@ -1,3 +0,0 @@ | |||
| The contents of */octicons* */svg* are generated by an automated process. Changes to these files may be accepted, but may also be overwritten. | |||
|
|
|||
| Octicons are a scalable set of icons created by GitHub. At this time, new icons will only be added when they are needed for GitHub products. | |||
There was a problem hiding this comment.
At this time, new icons will only be added when they are needed for GitHub products.
Is this statement still accurate or not anymore? It was removed here, and I can't find it re-added anywhere else.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After trials and errors with the Mono-repository in primer-css We have decided that doing the same thing with octicons would be beneficial to our workflow.
This PR updates the the octicons repositories to modules in one repo.
While working on this, @shawnbot and I accidentally published the next version of octicons 7.0.0. So the release notes are included in this PR.