Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for primary color in cvd modes #555

Merged
merged 5 commits into from
Apr 5, 2023
Merged

Fix for primary color in cvd modes #555

merged 5 commits into from
Apr 5, 2023

Conversation

lukasoppermann
Copy link
Contributor

Summary

Adds an exception for primary to allow color modes to keep the correct color.

@lukasoppermann lukasoppermann requested a review from a team as a code owner April 4, 2023 15:09
@lukasoppermann lukasoppermann requested review from a team, simurai and colebemis April 4, 2023 15:09
@changeset-bot
Copy link

changeset-bot bot commented Apr 4, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 79da867

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/primitives Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lukasoppermann lukasoppermann requested review from langermank and removed request for colebemis April 4, 2023 15:09
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023 •
edited
Loading

Variables changed ```diff --- base/dist/scss/colors/_dark.scss 2023-04-05 01:42:02.161757260 +0000 +++ dist/scss/colors/_dark.scss 2023-04-05 01:40:36.163075928 +0000 @@ -72,3 +72,3 @@ --color-codemirror-syntax-variable: #ffa657; - --color-checks-bg: #F10409; + --color-checks-bg: #010409; --color-checks-run-border-width: 1px; @@ -93,3 +93,3 @@ --color-checks-dropdown-border: #30363d; - --color-checks-dropdown-shadow: rgba(241,4,9,0.3); + --color-checks-dropdown-shadow: rgba(1,4,9,0.3); --color-checks-dropdown-hover-text: #e6edf3; @@ -165,3 +165,3 @@ --color-select-menu-tap-focus-bg: #0c2d6b; - --color-overlay-shadow: 0 0 0 1px #30363d, 0 16px 32px rgba(241,4,9,0.85); + --color-overlay-shadow: 0 0 0 1px #30363d, 0 16px 32px rgba(1,4,9,0.85); --color-header-text: rgba(255,255,255,0.7); @@ -222,3 +222,3 @@ --color-btn-outline-hover-border: rgba(240,246,252,0.1); - --color-btn-outline-hover-shadow: 0 1px 0 rgba(241,4,9,0.1); + --color-btn-outline-hover-shadow: 0 1px 0 rgba(1,4,9,0.1); --color-btn-outline-hover-inset-shadow: inset 0 1px 0 rgba(255,255,255,0.03); @@ -266,3 +266,3 @@ --color-switch-track-fg: #7d8590; - --color-switch-track-disabled-fg: #F10409; + --color-switch-track-disabled-fg: #010409; --color-switch-track-border: rgba(0,0,0,0); @@ -272,3 +272,3 @@ --color-switch-track-checked-fg: #ffffff; - --color-switch-track-checked-disabled-fg: #F10409; + --color-switch-track-checked-disabled-fg: #010409; --color-switch-track-checked-border: rgba(0,0,0,0); @@ -293,3 +293,3 @@ --color-canvas-overlay: #161b22; - --color-canvas-inset: #F10409; + --color-canvas-inset: #010409; --color-canvas-subtle: #161b22; @@ -299,5 +299,5 @@ --color-shadow-small: 0 0 transparent; - --color-shadow-medium: 0 3px 6px #F10409; - --color-shadow-large: 0 8px 24px #F10409; - --color-shadow-extra-large: 0 12px 48px #F10409; + --color-shadow-medium: 0 3px 6px #010409; + --color-shadow-large: 0 8px 24px #010409; + --color-shadow-extra-large: 0 12px 48px #010409; --color-neutral-emphasis-plus: #6e7681; @@ -343,3 +343,3 @@ --color-primer-fg-disabled: #484f58; - --color-primer-canvas-backdrop: rgba(241,4,9,0.8); + --color-primer-canvas-backdrop: rgba(1,4,9,0.8); --color-primer-canvas-sticky: rgba(13,17,23,0.95); @@ -349,3 +349,3 @@ --color-primer-shadow-inset: 0 0 transparent; - --color-scale-black: #F10409; + --color-scale-black: #010409; --color-scale-white: #ffffff; --- base/dist/scss/colors/_dark_colorblind.scss 2023-04-05 01:42:02.181757854 +0000 +++ dist/scss/colors/_dark_colorblind.scss 2023-04-05 01:40:36.183076363 +0000 @@ -77,3 +77,3 @@ --color-checks-text-secondary: #7d8590; - --color-checks-text-link: #2f81f7; + --color-checks-text-link: #58a6ff; --color-checks-btn-icon: #7d8590; @@ -108,3 +108,3 @@ --color-checks-line-selected-bg: rgba(56,139,253,0.1); - --color-checks-line-selected-num-text: #2f81f7; + --color-checks-line-selected-num-text: #58a6ff; --color-checks-line-dt-fm-text: #ffffff; @@ -126,3 +126,3 @@ --color-checks-logline-warning-bg: rgba(187,128,9,0.15); - --color-checks-logline-command-text: #2f81f7; + --color-checks-logline-command-text: #58a6ff; --color-checks-logline-section-text: #58a6ff; @@ -306,3 +306,3 @@ --color-neutral-subtle: rgba(110,118,129,0.1); - --color-accent-fg: #2f81f7; + --color-accent-fg: #58a6ff; --color-accent-emphasis: #1f6feb; --- base/dist/scss/colors/_dark_high_contrast.scss 2023-04-05 01:42:02.177757735 +0000 +++ dist/scss/colors/_dark_high_contrast.scss 2023-04-05 01:40:36.175076189 +0000 @@ -77,3 +77,3 @@ --color-checks-text-secondary: #f0f3f6; - --color-checks-text-link: #2f81f7; + --color-checks-text-link: #71b7ff; --color-checks-btn-icon: #f0f3f6; @@ -108,3 +108,3 @@ --color-checks-line-selected-bg: rgba(64,158,255,0.1); - --color-checks-line-selected-num-text: #2f81f7; + --color-checks-line-selected-num-text: #71b7ff; --color-checks-line-dt-fm-text: #0a0c10; @@ -126,3 +126,3 @@ --color-checks-logline-warning-bg: rgba(224,155,19,0.15); - --color-checks-logline-command-text: #2f81f7; + --color-checks-logline-command-text: #71b7ff; --color-checks-logline-section-text: #26cd4d; @@ -306,3 +306,3 @@ --color-neutral-subtle: rgba(158,167,179,0.1); - --color-accent-fg: #2f81f7; + --color-accent-fg: #71b7ff; --color-accent-emphasis: #409eff; --- base/dist/scss/colors/_dark_tritanopia.scss 2023-04-05 01:42:02.181757854 +0000 +++ dist/scss/colors/_dark_tritanopia.scss 2023-04-05 01:40:36.187076450 +0000 @@ -77,3 +77,3 @@ --color-checks-text-secondary: #7d8590; - --color-checks-text-link: #2f81f7; + --color-checks-text-link: #58a6ff; --color-checks-btn-icon: #7d8590; @@ -108,3 +108,3 @@ --color-checks-line-selected-bg: rgba(56,139,253,0.1); - --color-checks-line-selected-num-text: #2f81f7; + --color-checks-line-selected-num-text: #58a6ff; --color-checks-line-dt-fm-text: #ffffff; @@ -126,3 +126,3 @@ --color-checks-logline-warning-bg: rgba(187,128,9,0.15); - --color-checks-logline-command-text: #2f81f7; + --color-checks-logline-command-text: #58a6ff; --color-checks-logline-section-text: #58a6ff; @@ -306,3 +306,3 @@ --color-neutral-subtle: rgba(110,118,129,0.1); - --color-accent-fg: #2f81f7; + --color-accent-fg: #58a6ff; --color-accent-emphasis: #1f6feb; --- base/dist/scss/colors/_light_colorblind.scss 2023-04-05 01:42:02.145756784 +0000 +++ dist/scss/colors/_light_colorblind.scss 2023-04-05 01:40:36.155075753 +0000 @@ -21,3 +21,3 @@ --color-diffstat-addition-border: rgba(27,31,36,0.15); - --color-diffstat-addition-bg: #1f883d; + --color-diffstat-addition-bg: #0969da; --color-search-keyword-hl: #fff8c5; @@ -88,3 +88,3 @@ --color-checks-donut-pending: #bf8700; - --color-checks-donut-success: #1f883d; + --color-checks-donut-success: #0969da; --color-checks-donut-neutral: #afb8c1; @@ -205,3 +205,3 @@ --color-btn-primary-text: #ffffff; - --color-btn-primary-bg: #1f883d; + --color-btn-primary-bg: #0969da; --color-btn-primary-border: rgba(27,31,36,0.15); @@ -260,3 +260,3 @@ --color-action-list-item-danger-active-bg: #fff5e8; - --color-action-list-item-danger-hover-text: #d1242f; + --color-action-list-item-danger-hover-text: #b35900; --color-switch-track-bg: #eaeef2; @@ -311,3 +311,3 @@ --color-success-fg: #0969da; - --color-success-emphasis: #1f883d; + --color-success-emphasis: #0969da; --color-success-muted: rgba(84,174,255,0.4); @@ -322,3 +322,3 @@ --color-severe-subtle: #fff5e8; - --color-danger-fg: #d1242f; + --color-danger-fg: #b35900; --color-danger-emphasis: #b35900; --- base/dist/scss/colors/_light_tritanopia.scss 2023-04-05 01:42:02.153757022 +0000 +++ dist/scss/colors/_light_tritanopia.scss 2023-04-05 01:40:36.159075840 +0000 @@ -21,3 +21,3 @@ --color-diffstat-addition-border: rgba(27,31,36,0.15); - --color-diffstat-addition-bg: #1f883d; + --color-diffstat-addition-bg: #0969da; --color-search-keyword-hl: #fff8c5; @@ -88,3 +88,3 @@ --color-checks-donut-pending: #bf8700; - --color-checks-donut-success: #1f883d; + --color-checks-donut-success: #0969da; --color-checks-donut-neutral: #afb8c1; @@ -205,3 +205,3 @@ --color-btn-primary-text: #ffffff; - --color-btn-primary-bg: #1f883d; + --color-btn-primary-bg: #0969da; --color-btn-primary-border: rgba(27,31,36,0.15); @@ -260,3 +260,3 @@ --color-action-list-item-danger-active-bg: #ffebe9; - --color-action-list-item-danger-hover-text: #d1242f; + --color-action-list-item-danger-hover-text: #cf222e; --color-switch-track-bg: #eaeef2; @@ -311,3 +311,3 @@ --color-success-fg: #0969da; - --color-success-emphasis: #1f883d; + --color-success-emphasis: #0969da; --color-success-muted: rgba(84,174,255,0.4); @@ -322,3 +322,3 @@ --color-severe-subtle: #ffebe9; - --color-danger-fg: #d1242f; + --color-danger-fg: #cf222e; --color-danger-emphasis: #cf222e; ```

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023 •
edited
Loading

Design Token Contrast Check

light: ✅ all checks passed

Show results table for theme: light
contrastPair pass contrastRatio minimumContrastRatio
fg.default vs. canvas.default ✅ 15.79:1 4.5:1
fg.muted vs. canvas.default ✅ 5.24:1 4.5:1
fg.subtle vs. canvas.default ✅ 4.54:1 4.5:1
fg.default vs. canvas.subtle ✅ 14.83:1 4.5:1
fg.muted vs. canvas.subtle ✅ 4.92:1 4.5:1
fg.default vs. canvas.inset ✅ 14.83:1 4.5:1
fg.muted vs. canvas.inset ✅ 4.92:1 4.5:1
fg.default vs. accent.fg ✅ 3.04:1 3:1
fg.default vs. fg.muted ✅ 3.01:1 3:1
fg.default vs. accent.subtle ✅ 13.88:1 4.5:1
fg.default vs. success.subtle ✅ 14.19:1 4.5:1
fg.default vs. open.subtle ✅ 14.19:1 4.5:1
fg.default vs. danger.subtle ✅ 13.77:1 4.5:1
fg.default vs. closed.subtle ✅ 13.77:1 4.5:1
fg.default vs. attention.subtle ✅ 14.65:1 4.5:1
fg.default vs. severe.subtle ✅ 14.26:1 4.5:1
fg.default vs. done.subtle ✅ 14.21:1 4.5:1
fg.default vs. sponsors.subtle ✅ 14.24:1 4.5:1
accent.fg vs. canvas.default ✅ 5.19:1 4.5:1
accent.fg vs. canvas.subtle ✅ 4.87:1 4.5:1
accent.fg vs. canvas.inset ✅ 4.87:1 4.5:1
success.fg vs. canvas.default ✅ 5.07:1 4.5:1
success.fg vs. canvas.subtle ✅ 4.77:1 4.5:1
success.fg vs. canvas.inset ✅ 4.77:1 4.5:1
open.fg vs. canvas.default ✅ 5.07:1 4.5:1
open.fg vs. canvas.subtle ✅ 4.77:1 4.5:1
open.fg vs. canvas.inset ✅ 4.77:1 4.5:1
danger.fg vs. canvas.default ✅ 5.24:1 4.5:1
danger.fg vs. canvas.subtle ✅ 4.92:1 4.5:1
danger.fg vs. canvas.inset ✅ 4.92:1 4.5:1
closed.fg vs. canvas.default ✅ 5.24:1 4.5:1
closed.fg vs. canvas.subtle ✅ 4.92:1 4.5:1
closed.fg vs. canvas.inset ✅ 4.92:1 4.5:1
attention.fg vs. canvas.default ✅ 4.86:1 4.5:1
attention.fg vs. canvas.subtle ✅ 4.57:1 4.5:1
attention.fg vs. canvas.inset ✅ 4.57:1 4.5:1
severe.fg vs. canvas.default ✅ 5.03:1 4.5:1
severe.fg vs. canvas.subtle ✅ 4.72:1 4.5:1
severe.fg vs. canvas.inset ✅ 4.72:1 4.5:1
done.fg vs. canvas.default ✅ 5.04:1 4.5:1
done.fg vs. canvas.subtle ✅ 4.73:1 4.5:1
done.fg vs. canvas.inset ✅ 4.73:1 4.5:1
sponsors.fg vs. canvas.default ✅ 5.04:1 4.5:1
sponsors.fg vs. canvas.subtle ✅ 4.73:1 4.5:1
sponsors.fg vs. canvas.inset ✅ 4.73:1 4.5:1
accent.fg vs. accent.subtle ✅ 4.56:1 4.5:1
success.fg vs. success.subtle ✅ 4.56:1 4.5:1
open.fg vs. open.subtle ✅ 4.56:1 4.5:1
danger.fg vs. danger.subtle ✅ 4.57:1 4.5:1
closed.fg vs. closed.subtle ✅ 4.57:1 4.5:1
attention.fg vs. attention.subtle ✅ 4.51:1 4.5:1
severe.fg vs. severe.subtle ✅ 4.54:1 4.5:1
done.fg vs. done.subtle ✅ 4.53:1 4.5:1
sponsors.fg vs. sponsors.subtle ✅ 4.55:1 4.5:1
accent.fg vs. fg.default ✅ 3.04:1 3:1
success.fg vs. fg.default ✅ 3.11:1 3:1
open.fg vs. fg.default ✅ 3.11:1 3:1
danger.fg vs. fg.default ✅ 3.01:1 3:1
closed.fg vs. fg.default ✅ 3.01:1 3:1
attention.fg vs. fg.default ✅ 3.24:1 3:1
severe.fg vs. fg.default ✅ 3.13:1 3:1
done.fg vs. fg.default ✅ 3.13:1 3:1
sponsors.fg vs. fg.default ✅ 3.13:1 3:1
fg.onEmphasis vs. neutral.emphasis ✅ 4.54:1 4.5:1
fg.onEmphasis vs. neutral.emphasisPlus ✅ 14.65:1 4.5:1
fg.onEmphasis vs. accent.emphasis ✅ 5.19:1 4.5:1
fg.onEmphasis vs. success.emphasis ✅ 4.51:1 4.5:1
fg.onEmphasis vs. open.emphasis ✅ 4.51:1 4.5:1
fg.onEmphasis vs. danger.emphasis ✅ 5.35:1 4.5:1
fg.onEmphasis vs. closed.emphasis ✅ 5.35:1 4.5:1
fg.onEmphasis vs. attention.emphasis ✅ 4.86:1 4.5:1
fg.onEmphasis vs. severe.emphasis ✅ 5.03:1 4.5:1
fg.onEmphasis vs. done.emphasis ✅ 5.04:1 4.5:1
fg.onEmphasis vs. sponsors.emphasis ✅ 5.04:1 4.5:1
control.borderColor.emphasis vs. canvas.default ✅ 3.28:1 3:1
control.borderColor.emphasis vs. canvas.subtle ✅ 3.08:1 3:1

dark: ❌ 9 checks failed

Show results table for theme: dark
contrastPair pass contrastRatio minimumContrastRatio
fg.default vs. canvas.default ✅ 16.01:1 4.5:1
fg.muted vs. canvas.default ✅ 5.07:1 4.5:1
fg.subtle vs. canvas.default ❌ 4.11:1 4.5:1
fg.default vs. canvas.subtle ✅ 14.63:1 4.5:1
fg.muted vs. canvas.subtle ✅ 4.63:1 4.5:1
fg.default vs. canvas.inset ✅ 17.37:1 4.5:1
fg.muted vs. canvas.inset ✅ 5.5:1 4.5:1
fg.default vs. accent.fg ✅ 3.17:1 3:1
fg.default vs. fg.muted ✅ 3.15:1 3:1
fg.default vs. accent.subtle on canvas.default ✅ 14.34:1 4.5:1
fg.default vs. accent.subtle on canvas.subtle ✅ 12.91:1 4.5:1
fg.default vs. success.subtle on canvas.default ✅ 13.44:1 4.5:1
fg.default vs. success.subtle on canvas.subtle ✅ 12:1 4.5:1
fg.default vs. open.subtle on canvas.default ✅ 13.44:1 4.5:1
fg.default vs. open.subtle on canvas.subtle ✅ 12:1 4.5:1
fg.default vs. danger.subtle on canvas.default ✅ 14.59:1 4.5:1
fg.default vs. danger.subtle on canvas.subtle ✅ 13.2:1 4.5:1
fg.default vs. closed.subtle on canvas.default ✅ 13.64:1 4.5:1
fg.default vs. closed.subtle on canvas.subtle ✅ 12.34:1 4.5:1
fg.default vs. attention.subtle on canvas.default ✅ 13.4:1 4.5:1
fg.default vs. attention.subtle on canvas.subtle ✅ 12.08:1 4.5:1
fg.default vs. severe.subtle on canvas.default ✅ 14.45:1 4.5:1
fg.default vs. severe.subtle on canvas.subtle ✅ 13.03:1 4.5:1
fg.default vs. done.subtle on canvas.default ✅ 14.28:1 4.5:1
fg.default vs. done.subtle on canvas.subtle ✅ 12.85:1 4.5:1
fg.default vs. sponsors.subtle on canvas.default ✅ 14.4:1 4.5:1
fg.default vs. sponsors.subtle on canvas.subtle ✅ 12.98:1 4.5:1
accent.fg vs. canvas.default ✅ 5.05:1 4.5:1
accent.fg vs. canvas.subtle ✅ 4.61:1 4.5:1
accent.fg vs. canvas.inset ✅ 5.48:1 4.5:1
success.fg vs. canvas.default ✅ 7.44:1 4.5:1
success.fg vs. canvas.subtle ✅ 6.8:1 4.5:1
success.fg vs. canvas.inset ✅ 8.08:1 4.5:1
open.fg vs. canvas.default ✅ 7.44:1 4.5:1
open.fg vs. canvas.subtle ✅ 6.8:1 4.5:1
open.fg vs. canvas.inset ✅ 8.08:1 4.5:1
danger.fg vs. canvas.default ✅ 5.64:1 4.5:1
danger.fg vs. canvas.subtle ✅ 5.16:1 4.5:1
danger.fg vs. canvas.inset ✅ 6.12:1 4.5:1
closed.fg vs. canvas.default ✅ 5.64:1 4.5:1
closed.fg vs. canvas.subtle ✅ 5.16:1 4.5:1
closed.fg vs. canvas.inset ✅ 6.12:1 4.5:1
attention.fg vs. canvas.default ✅ 7.49:1 4.5:1
attention.fg vs. canvas.subtle ✅ 6.85:1 4.5:1
attention.fg vs. canvas.inset ✅ 8.13:1 4.5:1
severe.fg vs. canvas.default ✅ 5.61:1 4.5:1
severe.fg vs. canvas.subtle ✅ 5.13:1 4.5:1
severe.fg vs. canvas.inset ✅ 6.09:1 4.5:1
done.fg vs. canvas.default ✅ 5.64:1 4.5:1
done.fg vs. canvas.subtle ✅ 5.15:1 4.5:1
done.fg vs. canvas.inset ✅ 6.12:1 4.5:1
sponsors.fg vs. canvas.default ✅ 5.62:1 4.5:1
sponsors.fg vs. canvas.subtle ✅ 5.14:1 4.5:1
sponsors.fg vs. canvas.inset ✅ 6.1:1 4.5:1
accent.fg vs. accent.subtle on canvas.default ✅ 4.52:1 4.5:1
success.fg vs. success.subtle on canvas.default ✅ 6.25:1 4.5:1
success.fg vs. success.subtle on canvas.subtle ✅ 5.58:1 4.5:1
open.fg vs. open.subtle on canvas.default ✅ 6.25:1 4.5:1
open.fg vs. open.subtle on canvas.subtle ✅ 5.58:1 4.5:1
danger.fg vs. danger.subtle on canvas.default ✅ 5.14:1 4.5:1
danger.fg vs. danger.subtle on canvas.subtle ✅ 4.65:1 4.5:1
closed.fg vs. closed.subtle on canvas.default ✅ 4.81:1 4.5:1
attention.fg vs. attention.subtle on canvas.default ✅ 6.27:1 4.5:1
attention.fg vs. attention.subtle on canvas.subtle ✅ 5.65:1 4.5:1
severe.fg vs. severe.subtle on canvas.default ✅ 5.06:1 4.5:1
severe.fg vs. severe.subtle on canvas.subtle ✅ 4.57:1 4.5:1
done.fg vs. done.subtle on canvas.default ✅ 5.03:1 4.5:1
done.fg vs. done.subtle on canvas.subtle ✅ 4.52:1 4.5:1
sponsors.fg vs. sponsors.subtle on canvas.default ✅ 5.06:1 4.5:1
sponsors.fg vs. sponsors.subtle on canvas.subtle ✅ 4.56:1 4.5:1
accent.fg vs. fg.default ✅ 3.17:1 3:1
success.fg vs. fg.default ❌ 2.14:1 3:1
open.fg vs. fg.default ❌ 2.14:1 3:1
danger.fg vs. fg.default ❌ 2.83:1 3:1
closed.fg vs. fg.default ❌ 2.83:1 3:1
attention.fg vs. fg.default ❌ 2.13:1 3:1
severe.fg vs. fg.default ❌ 2.85:1 3:1
done.fg vs. fg.default ❌ 2.83:1 3:1
sponsors.fg vs. fg.default ❌ 2.84:1 3:1
fg.onEmphasis vs. neutral.emphasis ✅ 4.59:1 4.5:1
fg.onEmphasis vs. neutral.emphasisPlus ✅ 4.59:1 4.5:1
fg.onEmphasis vs. accent.emphasis ✅ 4.63:1 4.5:1
fg.onEmphasis vs. success.emphasis ✅ 4.63:1 4.5:1
fg.onEmphasis vs. open.emphasis ✅ 4.63:1 4.5:1
fg.onEmphasis vs. danger.emphasis ✅ 4.6:1 4.5:1
fg.onEmphasis vs. closed.emphasis ✅ 4.6:1 4.5:1
fg.onEmphasis vs. attention.emphasis ✅ 4.64:1 4.5:1
fg.onEmphasis vs. severe.emphasis ✅ 4.65:1 4.5:1
fg.onEmphasis vs. done.emphasis ✅ 4.6:1 4.5:1
fg.onEmphasis vs. sponsors.emphasis ✅ 4.57:1 4.5:1
control.borderColor.emphasis vs. canvas.default ✅ 3.31:1 3:1
control.borderColor.emphasis vs. canvas.subtle ✅ 3.02:1 3:1

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023 •
edited
Loading

🟢 No design token changes found

@lukasoppermann lukasoppermann temporarily deployed to github-pages April 4, 2023 15:14 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview April 4, 2023 15:15 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview April 4, 2023 15:20 Inactive
@lukasoppermann lukasoppermann temporarily deployed to github-pages April 4, 2023 15:24 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview April 4, 2023 15:24 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview April 4, 2023 15:25 Inactive
simurai
simurai approved these changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@simurai simurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understood the changes correctly:

  • the change from black: #F10409, to black: #010409 was just a typo
  • adding all the exceptions for accent-fg to blue.3 is needed since we changed the "base/default" dark theme and all the other themes inherit the change
  • success.emphasis + danger.fg in color blind is needed because it uses a hardcoded value in the "base/default" theme

Ok, yes.. I think this all makes sense. 👍 I can merge and create a new release and add it to dotcom.

@github-actions github-actions bot temporarily deployed to storybook-preview April 5, 2023 01:45 Inactive
@simurai simurai merged commit 98ca36a into main Apr 5, 2023
@simurai simurai deleted the color-mode-patches branch April 5, 2023 02:00
@primer-css primer-css mentioned this pull request Apr 5, 2023
Merged
This was referenced Apr 5, 2023
Merged
Merged
langermank pushed a commit that referenced this pull request Apr 19, 2023
@lukasoppermann @simurai @langermank
Fix for primary color in cvd modes (#555)
3ee08cd 
* fix for primary color in cvd modes

* fix for danger.fg

* fix for accent in dark mode

* bugfix

* Create .changeset/polite-penguins-wonder.md

---------

Co-authored-by: simurai <simurai@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langermank langermank langermank approved these changes

@simurai simurai simurai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukasoppermann @simurai @langermank