Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update color variables in SelectMenu #1098

Merged
merged 12 commits into from
Mar 4, 2021
Merged

Update color variables in SelectMenu #1098

merged 12 commits into from
Mar 4, 2021

Conversation

bscofield
Copy link

@bscofield bscofield commented Mar 1, 2021

Updating SelectMenu and its children

@changeset-bot
Copy link

changeset-bot bot commented Mar 1, 2021

🦋 Changeset detected

Latest commit: 886b1ed

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Mar 1, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-components/EFf8YznxVgZJPhq6wWJv7DJwdotX
✅ Preview: https://primer-components-git-bs-functional-vars-2-primer.vercel.app

@vercel vercel bot temporarily deployed to Preview March 1, 2021 18:32 Inactive
@vercel vercel bot temporarily deployed to Preview March 1, 2021 18:49 Inactive
@vercel vercel bot temporarily deployed to Preview March 1, 2021 18:54 Inactive
@vercel vercel bot temporarily deployed to Preview March 1, 2021 19:12 Inactive
@vercel vercel bot temporarily deployed to Preview March 1, 2021 19:58 Inactive
@vercel vercel bot temporarily deployed to Preview March 1, 2021 20:24 Inactive
@vercel vercel bot temporarily deployed to Preview March 2, 2021 12:21 Inactive
@vercel vercel bot temporarily deployed to Preview March 2, 2021 12:33 Inactive
@vercel vercel bot temporarily deployed to Preview March 2, 2021 12:47 Inactive
@vercel vercel bot temporarily deployed to Preview March 2, 2021 12:51 Inactive
@vercel vercel bot temporarily deployed to Preview March 2, 2021 13:41 Inactive
@vercel vercel bot temporarily deployed to Preview March 2, 2021 13:44 Inactive
@vercel vercel bot temporarily deployed to Preview March 2, 2021 13:52 Inactive
@vercel vercel bot temporarily deployed to Preview March 2, 2021 13:56 Inactive
@vercel vercel bot temporarily deployed to Preview March 2, 2021 14:04 Inactive
@vercel vercel bot temporarily deployed to Preview March 2, 2021 14:20 Inactive
@vercel vercel bot temporarily deployed to Preview March 2, 2021 14:31 Inactive
@vercel vercel bot temporarily deployed to Preview March 2, 2021 14:36 Inactive
@vercel vercel bot temporarily deployed to Preview March 2, 2021 14:45 Inactive
@vercel vercel bot temporarily deployed to Preview March 2, 2021 14:50 Inactive
@vercel vercel bot temporarily deployed to Preview March 2, 2021 15:00 Inactive
@vercel vercel bot temporarily deployed to Preview March 2, 2021 15:11 Inactive
@vercel vercel bot temporarily deployed to Preview March 2, 2021 15:18 Inactive
@vercel vercel bot temporarily deployed to Preview March 2, 2021 15:28 Inactive
@vercel vercel bot temporarily deployed to Preview March 2, 2021 17:35 Inactive
@vercel vercel bot temporarily deployed to Preview March 2, 2021 17:43 Inactive
@vercel vercel bot temporarily deployed to Preview March 2, 2021 17:53 Inactive
@vercel vercel bot temporarily deployed to Preview March 2, 2021 18:03 Inactive
@vercel vercel bot temporarily deployed to Preview March 2, 2021 18:07 Inactive
@vercel vercel bot temporarily deployed to Preview March 2, 2021 20:05 Inactive
@vercel vercel bot temporarily deployed to Preview March 2, 2021 20:57 Inactive
@bscofield bscofield marked this pull request as ready for review March 2, 2021 21:41
@bscofield bscofield changed the title Update color variables (BDS) - 2 Update color variables in SelectMenu Mar 2, 2021
@vercel vercel bot temporarily deployed to Preview March 3, 2021 17:41 Inactive
Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just left a few suggestions. After those are resolved and you've added a changeset this PR should be good to go 🚢

Co-authored-by: Cole Bemis <colebemis@github.com>
@vercel vercel bot temporarily deployed to Preview March 4, 2021 01:02 Inactive
@vercel vercel bot temporarily deployed to Preview March 4, 2021 01:09 Inactive
@bscofield
Copy link
Author

@colebemis 👍 changes merged, changeset added, ready for merge when you have time

@vercel vercel bot temporarily deployed to Preview March 4, 2021 07:05 Inactive
@colebemis colebemis merged commit 9908cfd into main Mar 4, 2021
@colebemis colebemis deleted the bs-functional-vars-2 branch March 4, 2021 07:29
@github-actions github-actions bot mentioned this pull request Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants