Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export use confirm hook and confirmation dialog #1195

Merged
merged 5 commits into from
May 5, 2021

Conversation

VanAnderson
Copy link
Contributor

Export ConfirmationDialog and useConfirm from index.

https://github.slack.com/archives/C01L618AEP9/p1619730448377100

@changeset-bot
Copy link

changeset-bot bot commented Apr 29, 2021

🦋 Changeset detected

Latest commit: 64d3d69

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Apr 29, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-components/9ziS2dxXRP1E6ARnpLQUqAuMLtxu
✅ Preview: https://primer-components-git-vananderson-fix-exports-primer.vercel.app

@smockle
Copy link
Member

smockle commented Apr 30, 2021

Running yarn run dist locally gave me these warnings, which may be related to why CI is failing:

[dist:rollup] (!) Circular dependencies
[dist:rollup] src/index.ts -> src/Dialog/ConfirmationDialog.tsx -> src/index.ts
[dist:rollup] src/index.ts -> src/Dialog/ConfirmationDialog.tsx -> src/Dialog/Dialog.tsx -> src/index.ts
[dist:rollup] src/index.ts -> src/ActionList/index.ts -> src/ActionList/List.tsx -> src/ActionList/Item.tsx -> src/index.ts

Update: Fixed in be4febc, basically by replacing imports from .. (index.ts, barrel) with imports from explicit individual module paths.

@vercel vercel bot temporarily deployed to Preview April 30, 2021 21:50 Inactive
@vercel vercel bot temporarily deployed to Preview April 30, 2021 21:53 Inactive
@vercel vercel bot temporarily deployed to Preview May 4, 2021 19:10 Inactive
@VanAnderson VanAnderson merged commit 4c2e1a2 into main May 5, 2021
@VanAnderson VanAnderson deleted the VanAnderson/fix-exports branch May 5, 2021 17:58
@github-actions github-actions bot mentioned this pull request May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants