Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog Focus Fix #1235

Merged
merged 5 commits into from
May 20, 2021
Merged

Dialog Focus Fix #1235

merged 5 commits into from
May 20, 2021

Conversation

VanAnderson
Copy link
Contributor

Small tweak to how dialog initial focus works.

@changeset-bot
Copy link

changeset-bot bot commented May 18, 2021

🦋 Changeset detected

Latest commit: 221f61f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented May 18, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-components/8n7TjciwnLPY966njZyBfkULTa31
✅ Preview: https://primer-components-git-vananderson-action-menu-on-confirm-primer.vercel.app

@vercel vercel bot temporarily deployed to Preview May 18, 2021 16:35 Inactive
@VanAnderson VanAnderson force-pushed the VanAnderson/action-menu-on-confirm branch from 2d99788 to 2ec6c7b Compare May 18, 2021 16:50
@vercel vercel bot temporarily deployed to Preview May 19, 2021 03:15 Inactive
@vercel vercel bot temporarily deployed to Preview May 19, 2021 03:18 Inactive
@VanAnderson VanAnderson marked this pull request as ready for review May 20, 2021 14:44
@vercel vercel bot temporarily deployed to Preview May 20, 2021 15:06 Inactive
@VanAnderson VanAnderson changed the title WIP Dialog Focus Fix Dialog Focus Fix May 20, 2021
@vercel vercel bot temporarily deployed to Preview May 20, 2021 15:49 Inactive
Copy link
Member

@dgreif dgreif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, seems less hacky than the setTimeout for sure 😄

@dgreif dgreif enabled auto-merge (squash) May 20, 2021 16:06
@dgreif dgreif merged commit e009e32 into main May 20, 2021
@dgreif dgreif deleted the VanAnderson/action-menu-on-confirm branch May 20, 2021 16:17
@github-actions github-actions bot mentioned this pull request May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants