Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ActionList): description font size and truncation #1253

Merged
merged 7 commits into from
May 27, 2021

Conversation

dgreif
Copy link
Member

@dgreif dgreif commented May 25, 2021

Fixing a couple small issues with ActionList.Item styles:

  • Description font size should be 12px instead of 14px
  • Inline descriptions should be truncated with ellipsis, rather than wrapping. I had to redo the flex styles a bit to make the main text area grow properly.

Also added a new story for stress testing these styles

Screenshots

image

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@dgreif dgreif requested a review from smockle May 25, 2021 21:21
@changeset-bot
Copy link

changeset-bot bot commented May 25, 2021

🦋 Changeset detected

Latest commit: eafa1b5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented May 25, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-components/9RfpK7wv4j2csBPA2NrjADhqDVRW
✅ Preview: https://primer-components-git-item-description-styles-primer.vercel.app

@vercel vercel bot temporarily deployed to Preview May 25, 2021 21:34 Inactive
@vercel vercel bot temporarily deployed to Preview May 25, 2021 21:38 Inactive
@vercel vercel bot temporarily deployed to Preview May 25, 2021 21:53 Inactive
@vercel vercel bot temporarily deployed to Preview May 26, 2021 04:24 Inactive
@vercel vercel bot temporarily deployed to Preview May 26, 2021 19:33 Inactive
@vercel vercel bot temporarily deployed to Preview May 27, 2021 14:27 Inactive
@dgreif dgreif merged commit 25d88c4 into main May 27, 2021
@dgreif dgreif deleted the item-description-styles branch May 27, 2021 14:42
@github-actions github-actions bot mentioned this pull request May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants