Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make top and left position explicit props of Overlay handled separately from other styles #1385

Merged
merged 6 commits into from
Aug 31, 2021

Conversation

jfuchs
Copy link
Contributor

@jfuchs jfuchs commented Aug 19, 2021

Make top and left position explicit props of Overlay handled separately from other styles. This is a follow-up to #1381, making top and left explicit required arguments to Overlay.

Screenshots

Please provide before/after screenshots for any visual changes

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@jfuchs jfuchs requested a review from dgreif August 19, 2021 19:07
@changeset-bot
Copy link

changeset-bot bot commented Aug 19, 2021

🦋 Changeset detected

Latest commit: 125b13d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 19, 2021

size-limit report 📦

Path Size
dist/browser.esm.js 48.41 KB (+0.03% 🔺)
dist/browser.umd.js 48.7 KB (+0.04% 🔺)

@colebemis
Copy link
Contributor

Can you update the Overlay docs to reflect these changes?

@colebemis colebemis merged commit 5470b61 into main Aug 31, 2021
@colebemis colebemis deleted the jfuchs/all-overlays-positioned-via-style-prop branch August 31, 2021 17:16
@primer-css primer-css mentioned this pull request Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants