Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos in TypeScript docs #1594

Merged
merged 1 commit into from
Nov 12, 2021
Merged

Fix typos in TypeScript docs #1594

merged 1 commit into from
Nov 12, 2021

Conversation

danielguillan
Copy link
Contributor

This PR fixes typos in the TypeScript section in the Getting Started docs.

@danielguillan danielguillan added the docs Documentation label Nov 10, 2021
@danielguillan danielguillan requested review from a team and colebemis November 10, 2021 18:08
@changeset-bot
Copy link

changeset-bot bot commented Nov 10, 2021

⚠️ No Changeset found

Latest commit: cd7f56b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@danielguillan danielguillan added the skip changeset This change does not need a changelog label Nov 10, 2021
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
dist/browser.esm.js 54.21 KB (0%)
dist/browser.umd.js 54.61 KB (0%)

jfuchs
jfuchs approved these changes Nov 10, 2021
View reviewed changes
Copy link
Contributor

@jfuchs jfuchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

rezrah
rezrah approved these changes Nov 10, 2021
View reviewed changes
Copy link
Contributor

@rezrah rezrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice spot @danielguillan 😄 👍

@colebemis colebemis merged commit 1b2f08d into main Nov 12, 2021
@colebemis colebemis deleted the danielguillan/fix-ts-docs-typos branch November 12, 2021 21:32
pksjce pushed a commit that referenced this pull request Nov 15, 2021
@danielguillan @pksjce
Fix TypeScript docs typo (#1594)
e822b86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rezrah rezrah rezrah approved these changes

@jfuchs jfuchs jfuchs approved these changes

@colebemis colebemis Awaiting requested review from colebemis

Assignees
No one assigned
Labels
docs Documentation skip changeset This change does not need a changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danielguillan @jfuchs @rezrah @colebemis