Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for draft issues to the StateLabel component #1604

Merged
merged 6 commits into from
Nov 15, 2021
Merged

Add support for draft issues to the StateLabel component #1604

merged 6 commits into from
Nov 15, 2021

Conversation

japf
Copy link
Contributor

@japf japf commented Nov 12, 2021

This support is adding support for draft issues to the <StateLabel> component.

Screenshots

  • Before

image

  • After

image

Merge checklist

  • Added/updated tests: looks like existing test does not have assertions at the icon level, so I didn't do any changes here.
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

@changeset-bot
Copy link

changeset-bot bot commented Nov 12, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: e88a61d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2021 •
edited
Loading

size-limit report 📦

Path Size
dist/browser.esm.js 54.96 KB (+0.97% 🔺)
dist/browser.umd.js 55.35 KB (+0.95% 🔺)

japf
japf commented Nov 12, 2021
View reviewed changes
package.json
@@ -43,7 +43,7 @@
"author": "GitHub, Inc.",
"license": "MIT",
"dependencies": {
"@primer/octicons-react": "^13.0.0",
"@primer/octicons-react": "^16.1.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new icon I'm using here (IssueDraftIcon) was added here primer/octicons#614 and shipped with version 14. I'm not sure how we update dependencies in such cases.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is likely causing some test failures right now 😢

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the snapshots are stale. Does running test:update command help the tests pass?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rezrah looks like they are passing now with dd6b246

@japf japf marked this pull request as ready for review November 12, 2021 14:54
@japf japf requested review from a team and siddharthkp November 12, 2021 14:54
@japf
Copy link
Contributor Author

japf commented Nov 15, 2021

I just had a look at the changes in the package-lock.json and I'll need to fix that before we can merge this PR:
image

@japf japf requested a review from rezrah November 15, 2021 09:36
@japf
Copy link
Contributor Author

japf commented Nov 15, 2021

I just had a look at the changes in the package-lock.json and I'll need to fix that before we can merge this PR: image

Fixed with a6e319f

The diff is looking good now:

image

@japf japf enabled auto-merge (squash) November 15, 2021 15:55
@japf japf merged commit d2090b5 into main Nov 15, 2021
@japf japf deleted the japf/state-label-draft-issue branch November 15, 2021 15:59
This was referenced Nov 15, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pksjce pksjce pksjce approved these changes

@siddharthkp siddharthkp Awaiting requested review from siddharthkp

@rezrah rezrah Awaiting requested review from rezrah

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@japf @pksjce @rezrah