Use extracted @primer/behaviors #1700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c49033b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
jfuchs
approved these changes
Dec 6, 2021
| @@ -9,5 +9,7 @@ module.exports = { | |||
| '<rootDir>/src/utils/test-deprecations.tsx', | |||
| '<rootDir>/src/utils/test-helpers.tsx' | |||
| ], | |||
| testMatch: ['<rootDir>/(src|codemods)/__tests__/**/*.test.[jt]s?(x)', '!**/*.types.test.[jt]s?(x)'] | |||
| testMatch: ['<rootDir>/(src|codemods)/__tests__/**/*.test.[jt]s?(x)', '!**/*.types.test.[jt]s?(x)'], | |||
| // @primer/behaviors is ESM, so needs to be transformed | |||
There was a problem hiding this comment.
nit: this didn't make sense to me — it seems like you're saying something needs to be transformed, but then the code seems like you're setting it to be ignored?
There was a problem hiding this comment.
Good old double negatives at work here. This is the transform ignore option, and we are passing it a regex for node_modules minus @primer/behaviors. By setting this option, we overwrite the default which is just node_modules
colebemis
reviewed
Dec 8, 2021
Co-authored-by: Cole Bemis <colebemis@github.com>
dgreif
force-pushed
the
primer-behaviors
branch
from
a36b667
to
c49033b
Compare
Merged
6 tasks
Merged
pksjce
pushed a commit
that referenced
this pull request
Dec 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in ADR 2, all of the "behaviors" in PRC have been written in vanilla javascript, with React Hooks that wrap the vanilla js behaviors. One of the reasons for this approach was that the behaviors could eventually be extracted and shared with other projects, like PVC and github/github. We have seen an increased need for a few of these behaviors on the github/github side, and have extracted the behaviors to a new @primer/behaviors package that can be shared. This PR removes all of the behaviors from the PRC project and pulls in @primer/behaviors as a replacement.
Closes https://github.com/github/primer/issues/483
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.