Let FormControl accept any input #1968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… spot we'd normally render a Primer input component
🦋 Changeset detectedLatest commit: aa500e9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
…nto mp/form-control-any-input
siddharthkp
approved these changes
Mar 16, 2022
Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com>
mperrotti
commented
Mar 16, 2022
| @@ -183,13 +175,8 @@ const FormControl = React.forwardRef<HTMLDivElement, FormControlProps>( | |||
| display="flex" | |||
| flexDirection="column" | |||
| width="100%" | |||
| sx={{...(isLabelHidden ? {'> *:not(label) + *': {marginTop: 2}} : {'> * + *': {marginTop: 2}}), ...sx}} | |||
| sx={{...(isLabelHidden ? {'> *:not(label) + *': {marginTop: 1}} : {'> * + *': {marginTop: 1}}), ...sx}} | |||
There was a problem hiding this comment.
This has nothing to do with accepting different input components.
I looked at this with fresh eyes and thought the elements were spaced too far apart.
Merged
pksjce
pushed a commit
that referenced
this pull request
Mar 17, 2022
* renders any non-FormControl components passed into FormControl in the spot we'd normally render a Primer input component * adds changeset * appease the linter * Update docs/content/FormControl.mdx Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com> * addresses PR feedback Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of rendering unexpected*
FormControlchildren before the other children, we render them in the same spot we'd normally render an input.* any component that is not a Primer input component or not in the
FormControlnamespaceCloses #1964
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.