Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests #21

Merged
merged 8 commits into from
May 21, 2018
Merged

Add tests #21

merged 8 commits into from
May 21, 2018

Conversation

shawnbot
Copy link
Contributor

@shawnbot shawnbot commented May 17, 2018 •
edited
Loading

This separates out the addition of our new test suite and Travis config from #16. Let's merge this first so that the diff for that PR is smaller.

  • Tidies up package.json fields
  • Adds Jest and an example (React) test
  • Adds Travis config to run tests on Node v8
  • Adds .nvmrc so you can run nvm use and get the right version

@shawnbot shawnbot mentioned this pull request May 17, 2018
Merged
4 tasks
@shawnbot shawnbot requested a review from a team May 21, 2018 19:50
emplums
emplums approved these changes May 21, 2018
View reviewed changes
Copy link

@emplums emplums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🎉 🌻 ✨

@shawnbot shawnbot merged commit 6972baf into master May 21, 2018
@shawnbot shawnbot deleted the add-tests branch May 21, 2018 20:07
@broccolini broccolini mentioned this pull request May 21, 2018
Closed
14 tasks
@shawnbot shawnbot mentioned this pull request May 21, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emplums emplums emplums approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shawnbot @emplums