-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix slots infinite rendering when no context
prop is provided
#2219
Conversation
🦋 Changeset detectedLatest commit: 9914932 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
Just realized I totally missed the existing slots test file. Going to put this back in draft for now until I fix that 😅 |
Fixed - deleted my new test and updated the existing ones to not always define the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
First, updated the slots tests to that the
context
prop is not always defined. This caused the tests to fail due to infinite rendering, as expected from #2187.Then, fixed the bug by defaulting
context
to a statically referenced frozen object instead of a new object on every render. This fixes #2187 and makes the tests pass ✅.Merge checklist
[ ] Added/updated documentation