Update FilteredSearch docs and fix the z-index issue #2242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 923e219 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
broccolinisoup
commented
Aug 18, 2022
size-limit report 📦
|
broccolinisoup
commented
Aug 18, 2022
broccolinisoup
changed the title
colebemis
approved these changes
Aug 18, 2022
There was a problem hiding this comment.
Looks great, @broccolinisoup! Could you add a changeset for the z-index fix?
Any tips for replicating the Issue 3 (In the description)? @colebemis |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes an internal Primer issue #887
There are a couple of issues on the FilteredSearch component docs.
Issue 1 : Misaligned icon
After the fix
Issue 2 : Z-index issue with FilteredSearch
This is not specified in the issue however, I came across this when I was building a primer prototype. You can checkout the demo to see replicated scenario starting at 2:17. Or briefly below.
TextInputWrapper.class.z-index.issue.FilteredSearch.mp4
Issue 3 : Jumpy Action List labels
You can see the screen recording on the issue but I am not able to replicate this at all. However, I suspect this would something to do with the Action Menu/List rather than FilteredSearch.
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.