Add hooks to draft exports #2260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bebfd94 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
iansan5653
commented
Aug 23, 2022
| @@ -39,5 +39,5 @@ export type {MarkdownEditorProps} from './MarkdownEditor' | |||
| export type {Emoji} from './suggestions/_useEmojiSuggestions' | |||
| export type {Mentionable} from './suggestions/_useMentionSuggestions' | |||
| export type {Reference} from './suggestions/_useReferenceSuggestions' | |||
| export type {FileUploadResult} from './_useFileHandling' | |||
| export type {FileUploadResult, FileType} from './_useFileHandling' | |||
There was a problem hiding this comment.
I added FileType to the MarkdownEditor exports because it's useful when building the acceptedFileTypes prop.
size-limit report 📦
|
iansan5653
commented
Aug 23, 2022
| @@ -0,0 +1,5 @@ | |||
| export * from './useCombobox' | |||
There was a problem hiding this comment.
I wasn't 100% sure if I can just export * vs calling out each export type individually, but it appears to work fine based on the export * from './MarkdownViewer' in the drafts/index.ts file.
colebemis
approved these changes
Aug 23, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very minor PR to add the hooks in
drafts/hooks/to the exports defined indrafts/index.ts. I intended to do this when I introduced them but forgot.The only hook I excluded is
useUnifiedFileSelectbecause I think the use-case is fairly specific here and it's not worth making it public if we want to more easily change the implementation later. If someone requests it we can export it.