Fix small bugs in InlineAutocomplete
#2318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a5faa74 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
colebemis
approved these changes
Sep 8, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aria-livehint text for screen readers related to theInlineAutocompletecomponent is visually hidden withclip-path: circle(0), but this doesn't remove it from the layout of the page. It's inside aPortalcomponent so it renders into theprimerPortalRootportal. Because the hint text element is only visually hidden, it could cause the portal root to push page content around unintentionally. To fix this, I have addedposition: absoluteto the element to remove it from the page flow.ActionListitems when there is no selecting enabled. A previous hack to hide that element so it wouldn't indent items is now breaking the leading icons inInlineAutocompletesuggestions, preventing the emojis and other icons from appearing. The simple fix for this is to remove the styling hack.