Fix small bugs in InlineAutocomplete
#2318
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aria-live
hint text for screen readers related to theInlineAutocomplete
component is visually hidden withclip-path: circle(0)
, but this doesn't remove it from the layout of the page. It's inside aPortal
component so it renders into theprimerPortalRoot
portal. Because the hint text element is only visually hidden, it could cause the portal root to push page content around unintentionally. To fix this, I have addedposition: absolute
to the element to remove it from the page flow.ActionList
items when there is no selecting enabled. A previous hack to hide that element so it wouldn't indent items is now breaking the leading icons inInlineAutocomplete
suggestions, preventing the emojis and other icons from appearing. The simple fix for this is to remove the styling hack.