Revert "SelectPanel: Accessibility remediation (#2138)" #2338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ace38af.
🦋 Changeset detectedLatest commit: c72abae The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
colebemis
approved these changes
Sep 14, 2022
shiftkey
reviewed
Sep 15, 2022
siddharthkp
approved these changes
Sep 15, 2022
|
Sorry, pressed the wrong button by mistake 😅 I wasn't trying to re-request review from Cole
|
joshblack
approved these changes
Sep 15, 2022
6 tasks
Co-authored-by: Brendan Forster <github@brendanforster.com>
|
Just to note here that this PR is still awaiting open due to open discussion here |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit ace38af.
The 35.8.0 react release introduced breaking behavioural changes on SelectPanel so we are rolling back this commit and will release the select panel changes as a draft to avoid causing issues for consumers.
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.