feat(bundle): add exports for test-helpers #2419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0095409 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
… into fix/update-utils-entrypoint
|
Update: I looked at every diff in For a quick review + merge, can we break this PR into the immediate hotfix of shipping test-helpers and long term improvements? |
joshblack
commented
Oct 11, 2022
siddharthkp
approved these changes
Oct 11, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Certain files from
utilsare not included in the package, specifically if they are not imported by a file through an entrypoint (likesrc/utils/test-helpers.tsx)Approach
This PR adds additional entrypoints for files expected to be in the package. Currently, files under
utilswill not be included in the bundle unless they are referenced/imported by existing code. In the case of test helpers, this file is now explicitly included as it's export pattern would not fall under the existinglib-esm/*.