TreeView: Use roving tabIndex for focus management #2443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Josh Black <joshblack@users.noreply.github.com>
🦋 Changeset detectedLatest commit: d7967da The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
joshblack
approved these changes
Oct 18, 2022
| <> | ||
| <VisuallyHidden role="status" aria-live="polite"> | ||
| {ariaLiveMessage} | ||
| </VisuallyHidden> | ||
| <UlBox | ||
| ref={containerRef} | ||
| tabIndex={0} |
kendallgassner
approved these changes
Oct 18, 2022
|
|
||
| case 'ArrowRight': | ||
| event.preventDefault() | ||
| event.stopPropagation() |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced
aria-activedescendantwith a roving tab index in TreeView based on feedback from the accessibility engineering review.This is not a consumer-facing change. The keyboard navigation should work the same as it did before.
👉 Try it out
CleanShot.2022-10-17.at.15.09.52.mp4
Known issue
If you focus on a loading item and the async request fails, focus is lost after closing the error dialog:
CleanShot.2022-10-17.at.15.14.56.mp4
I'll fix this in a separate PR.
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.