-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TreeView: Create ErrorDialog component #2452
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 182bec9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
joshblack
reviewed
Oct 20, 2022
joshblack
approved these changes
Oct 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Love the API
Merged
josepmartins
pushed a commit
that referenced
this pull request
Oct 21, 2022
* Create TreeView.ErrorDialog component * Fix icon size * Add error dialog tests * Update docs * Create tough-lobsters-greet.md * Remove settimeout from test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems
Consumers have to make a lot of micro-decisions when using ConfirmationDialog with TreeView:
Keyboard events bubble up to the TreeView item when Dialog is open, causing items to expand and collapse unexpectedly.
Focus is lost when closing the Dialog:
CleanShot.2022-10-19.at.18.22.28.mp4
Solutions
This PR adds a
TreeView.ErrorDialog
component to wrapConfirmationDialog
and provide additional focus and event management.👉 Try it out
Focus is properly moved the parent item when a dialog closes:
CleanShot.2022-10-19.at.18.29.45.mp4
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.