TreeView: Performance improvements #2523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eeview-scroll-fix
🦋 Changeset detectedLatest commit: 438d653 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
siddharthkp
reviewed
Nov 3, 2022
src/TreeView/TreeView.tsx
Outdated
| } | ||
| } | ||
|
|
||
| .TreeView-item-container { |
There was a problem hiding this comment.
should we use [data-component] here instead to keep it future proof?
There was a problem hiding this comment.
Ideally, I'd like these names to be entirely private. In other words, I'm not ready to commit to the naming and "future proof" them. I've updated the code comment to clarify this and prefixed all classnames with PRIVATE_
Merged
broccolinisoup
pushed a commit
that referenced
this pull request
Nov 3, 2022
* Prevent focus event from bubbling to parent items * Update scroll story * Create violet-plants-sip.md * Ignore lint error * Update stress test * Lift styles to root * Remove unused imports * Remove unused sx prop * Clean up styles * Create tidy-olives-know.md * Update warning and prefix classnames with PRIVATE_ * Replace VisuallyHidden styled-component * Use VisuallyHidden component for root level live region * Update warning * Style directory icon without styled-components * Remove sx prop from item * Disable chromatic on TreeView stress test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
Opening a directory with 1000 files took 1.22s:
CleanShot.2022-11-02.at.16.36.13.mp4
After
Opening a directory with 1000 files now takes 590ms:
CleanShot.2022-11-02.at.16.38.20.mp4
Side-by-side
final_6362e660dbe31d0025fa3cd4_354575.mp4
Approach
To achieve these performance improvements, I moved the styles for tree items to the root level to avoid recomputing styles every time the tree updates. This is a temporary fix to enable the Repos team to use the TreeView component. We will need a system-level fix for styled-components performance soon. Writing performant components should be easy by default, and not require performance optimizations like this.
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.