Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storybook] Remove deprecated components in stories #2563

Merged
merged 10 commits into from
Nov 11, 2022

Conversation

josepmartins
Copy link
Contributor

@josepmartins josepmartins commented Nov 10, 2022

Remove deprecated component instances as we plan to heavily invest in Storybook and Lookbook as the primary source for code documentation.

Related: https://github.com/github/primer/issues/1375
Similar PR: #2555

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@josepmartins josepmartins requested review from a team and broccolinisoup November 10, 2022 16:05
@changeset-bot
Copy link

changeset-bot bot commented Nov 10, 2022

🦋 Changeset detected

Latest commit: 20cea00

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2022

size-limit report 📦

Path Size
dist/browser.esm.js 78.9 KB (0%)
dist/browser.umd.js 79.54 KB (0%)

@josepmartins josepmartins self-assigned this Nov 10, 2022
@josepmartins josepmartins temporarily deployed to github-pages November 10, 2022 16:21 Inactive
Copy link
Contributor

@langermank langermank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this is excellent! Great catch on this.

Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@josepmartins josepmartins temporarily deployed to github-pages November 11, 2022 08:02 Inactive
@josepmartins josepmartins merged commit 3085fde into main Nov 11, 2022
@josepmartins josepmartins deleted the josepmartins/storybook-deprecated-components branch November 11, 2022 08:12
@primer-css primer-css mentioned this pull request Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants