Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Noto Sans to fontStack #2721

Merged
merged 6 commits into from
Dec 26, 2022
Merged

Add Noto Sans to fontStack #2721

merged 6 commits into from
Dec 26, 2022

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Dec 22, 2022

This adds Noto Sans to the fontStack. It's a side-stream (not sure if that's a term 😆) from PCSS's primer/css#2300. It should improve alignment issues on Linux.

Closes https://github.com/github/primer/issues/1493

Screenshots

Before After
Screenshot from 2022-10-25 20-50-42 Screenshot from 2022-10-25 20-58-03

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@simurai simurai requested review from a team and josepmartins December 22, 2022 07:26
@changeset-bot
Copy link

changeset-bot bot commented Dec 22, 2022

🦋 Changeset detected

Latest commit: 19a27c0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Dec 22, 2022

size-limit report 📦

Path Size
dist/browser.esm.js 84.93 KB (+0.02% 🔺)
dist/browser.umd.js 85.53 KB (+0.02% 🔺)

@simurai simurai temporarily deployed to github-pages December 22, 2022 07:34 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2721 December 22, 2022 07:34 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2721 December 22, 2022 07:34 Inactive
Copy link
Contributor

@josepmartins josepmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ 🚢 !

@colebemis colebemis temporarily deployed to github-pages December 22, 2022 17:42 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2721 December 22, 2022 17:42 Inactive
@simurai simurai enabled auto-merge (squash) December 23, 2022 08:34
@simurai simurai temporarily deployed to github-pages December 23, 2022 08:43 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2721 December 23, 2022 08:43 Inactive
@simurai simurai temporarily deployed to github-pages December 26, 2022 02:57 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2721 December 26, 2022 02:58 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants