Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates ToggleSwitch to look less dimensional and more minimal #2843

Merged
merged 30 commits into from
Feb 24, 2023

Conversation

mperrotti
Copy link
Contributor

@mperrotti mperrotti commented Jan 30, 2023

These changes also include an update to the SegmentedControl color usage to match

Related Primitives PR that this is dependent on: primer/primitives#477
Related PVC PR: primer/view_components#1824

Merge checklist

  • Added/updated tests
  • [n/a] Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@mperrotti mperrotti requested review from a team and langermank January 30, 2023 23:23
@changeset-bot
Copy link

changeset-bot bot commented Jan 30, 2023

🦋 Changeset detected

Latest commit: c776359

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jan 30, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 94.3 KB (-0.3% 🔽)
dist/browser.umd.js 94.88 KB (-0.3% 🔽)

@github-actions github-actions bot temporarily deployed to storybook-preview-2843 January 30, 2023 23:29 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2843 January 30, 2023 23:30 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2843 January 30, 2023 23:33 Inactive
@mperrotti mperrotti force-pushed the mp/toggle-switch-style-updates branch from 4084222 to c8ee10f Compare February 4, 2023 00:52
@broccolinisoup broccolinisoup temporarily deployed to github-pages February 23, 2023 04:25 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2843 February 23, 2023 04:26 Inactive
@mperrotti mperrotti temporarily deployed to github-pages February 23, 2023 21:41 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2843 February 23, 2023 21:41 Inactive
@mperrotti mperrotti temporarily deployed to github-pages February 23, 2023 23:04 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2843 February 23, 2023 23:05 Inactive
@mperrotti mperrotti temporarily deployed to github-pages February 23, 2023 23:26 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2843 February 23, 2023 23:26 Inactive
src/theme-preval.js Outdated Show resolved Hide resolved
Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a comment to update the year other than that looks great to me 🚀

@github-actions github-actions bot temporarily deployed to storybook-preview-2843 February 23, 2023 23:52 Inactive
@mperrotti mperrotti temporarily deployed to github-pages February 23, 2023 23:53 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2843 February 23, 2023 23:53 Inactive
@mperrotti mperrotti temporarily deployed to github-pages February 24, 2023 14:29 — with GitHub Actions Inactive
@mperrotti mperrotti added this pull request to the merge queue Feb 24, 2023
Merged via the queue into main with commit 533f0b4 Feb 24, 2023
@mperrotti mperrotti deleted the mp/toggle-switch-style-updates branch February 24, 2023 14:48
@primer-css primer-css mentioned this pull request Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants