Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Avatar): move files to folder, add e2e tests and stories #2904

Merged
merged 9 commits into from
Feb 17, 2023

Conversation

josepmartins
Copy link
Contributor

@josepmartins josepmartins commented Feb 16, 2023

Tracking issue: https://github.com/github/primer/issues/1488

Add storybook stories for Avatar

Checklist

  • Ensure your chosen component has a component directory in the src directory
  • Ensure the component has a root story file in the component directory
  • Ensure that the root story file exports a Default story
  • (Optional) Create a Playground story
  • Move all other stories for the component into a .features.stories.tsx file
  • Opt the component into storybook tests
  • (Optional) Create visual regression tests for the component

@changeset-bot
Copy link

changeset-bot bot commented Feb 16, 2023

⚠️ No Changeset found

Latest commit: e377015

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@josepmartins josepmartins changed the title refactor(Avatar): move files to folder, add e2e tests and stories #2876 refactor(Avatar): move files to folder, add e2e tests and stories Feb 16, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 16, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 89.74 KB (+0.01% 🔺)
dist/browser.umd.js 90.28 KB (+0.01% 🔺)

@josepmartins josepmartins added skip changeset This change does not need a changelog update snapshots labels Feb 16, 2023
@github-actions github-actions bot temporarily deployed to storybook-preview-2904 February 16, 2023 14:41 Inactive
@josepmartins josepmartins temporarily deployed to github-pages February 16, 2023 14:49 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2904 February 16, 2023 14:49 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2904 February 16, 2023 15:01 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2904 February 16, 2023 15:01 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2904 February 16, 2023 15:05 Inactive
@josepmartins josepmartins marked this pull request as ready for review February 16, 2023 15:07
@josepmartins josepmartins requested a review from a team February 16, 2023 15:07
@josepmartins josepmartins temporarily deployed to github-pages February 16, 2023 15:08 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2904 February 16, 2023 15:09 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2904 February 16, 2023 15:10 Inactive
Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💖

@colebemis colebemis added this pull request to the merge queue Feb 17, 2023
Merged via the queue into main with commit 55a1ce5 Feb 17, 2023
@colebemis colebemis deleted the docs/add-avatar-stories branch February 17, 2023 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants