Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hidden: rename prop on -> when and reformat stories and add e2e tests #2985

Merged
merged 7 commits into from
Mar 8, 2023

Conversation

broccolinisoup
Copy link
Member

@broccolinisoup broccolinisoup commented Mar 6, 2023

Renames the prop from being on -> when as discussed with the team on React Eng Sync. Because Hidden is a draft component, it is okay to release this as minor.

Also reformats the storybook and addes e2e tests.

For reformatting, the tracking issue: https://github.com/github/primer/issues/1488

Add storybook stories for Hidden

Checklist

  • Ensure your chosen component has a component directory in the src directory
  • Ensure the component has a root story file in the component directory
  • Ensure that the root story file exports a Default story
  • (Optional) Create a Playground story
  • Move all other stories for the component into a .features.stories.tsx file
  • Opt the component into storybook tests
  • (Optional) Create visual regression tests for the component

@broccolinisoup broccolinisoup added the skip changeset This change does not need a changelog label Mar 6, 2023
@changeset-bot
Copy link

changeset-bot bot commented Mar 6, 2023

🦋 Changeset detected

Latest commit: e9309cf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 94.68 KB (0%)
dist/browser.umd.js 95.25 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-2985 March 6, 2023 06:18 Inactive
@primer primer bot temporarily deployed to github-pages March 6, 2023 06:19 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2985 March 6, 2023 06:19 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2985 March 8, 2023 02:55 Inactive
@primer primer bot temporarily deployed to github-pages March 8, 2023 02:56 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2985 March 8, 2023 02:57 Inactive
@primer primer bot temporarily deployed to github-pages March 8, 2023 03:36 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2985 March 8, 2023 03:37 Inactive
@broccolinisoup broccolinisoup marked this pull request as ready for review March 8, 2023 04:05
@broccolinisoup broccolinisoup requested review from a team and langermank March 8, 2023 04:05
@broccolinisoup broccolinisoup added this pull request to the merge queue Mar 8, 2023
Merged via the queue into main with commit 38ac17a Mar 8, 2023
@broccolinisoup broccolinisoup deleted the refactor-hidden branch March 8, 2023 20:32
@primer-css primer-css mentioned this pull request Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants