Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Button): remove required field for count prop docs #4520

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

joshblack
Copy link
Member

Closes #4519

Changelog

New

Changed

  • Update docs for Button so that count is not listed as required

Removed

Rollout strategy

  • None; if selected, include a brief description as to why

This is a docs change and will not impact the public API of the component.

@joshblack joshblack requested a review from a team as a code owner April 22, 2024 14:14
@joshblack joshblack requested a review from jonrohan April 22, 2024 14:14
Copy link

changeset-bot bot commented Apr 22, 2024

⚠️ No Changeset found

Latest commit: 977f949

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 88.03 KB (0%)
packages/react/dist/browser.umd.js 88.36 KB (0%)

@joshblack joshblack added this pull request to the merge queue Apr 22, 2024
Merged via the queue into main with commit 2621c07 Apr 22, 2024
33 of 34 checks passed
@joshblack joshblack deleted the 4519-remove-required-count branch April 22, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update docs for Button to not consider count as required
2 participants