Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check integration test results #4599

Closed
wants to merge 30 commits into from

Conversation

siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented May 16, 2024

Context

I'd like to fetch and report the result of golden-jobs-results on the PR as a CI check and comment.

Strategy 1: Pull (implemented here)

  1. Check if there is a PR related to current branch
  2. Check if the CI workflows have run
  3. Check if golden-jobs-results has completed yet
  4. Check results of golden-jobs-results

Strategy 2: Push (probably better!)

  1. Inform PR has been created (based on label)
  2. (maybe) inform golden-jobs-results has started/expected
  3. Inform golden-jobs-results has completed with results (based on label)

Questions I need to think more about:

  1. What triggers this workflow?
  2. Can this workflow be re-triggered manually?
  3. Is it workflow required or just recommended?
  4. What happens when this workflow fails for reasons not related to your PR/change
  5. Pushing another commit should invalidate the results, right?

Rollout strategy

  • None; workflow only change.

@siddharthkp siddharthkp added the skip changeset This change does not need a changelog label May 16, 2024
@siddharthkp siddharthkp self-assigned this May 16, 2024
Copy link

changeset-bot bot commented May 16, 2024

⚠️ No Changeset found

Latest commit: b436453

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented May 16, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 88.49 KB (0%)
packages/react/dist/browser.umd.js 88.84 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-4599 May 16, 2024 14:47 Inactive
Comment on lines +36 to +41
const { data } = await github.rest.repos.getBranch({
owner: 'github',
repo: 'github',
branch: BRANCH
});
core.setOutput('branch', BRANCH);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of us calling out to the repo directly, do you think it would be possible for us to use repository dispatch to coordinate between github/github and primer/react? The advantage of this would be that we wouldn't need to have a token/app that has permissions to github/github in CI.

Copy link
Member Author

@siddharthkp siddharthkp May 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely possible! 👀 Hopefully we can make them as granular.

The advantage of this would be that we wouldn't need to have a token/app that has permissions to github/github in CI.

We would still need a token that can do the first repository dispatch to trigger primer-react-pr-test workflow (not included in this PR). But, that would need significantly lower permissions which is better?

@primer-integration
Copy link

Integration PR has been created

@siddharthkp siddharthkp deleted the sid/poll-for-integration-results branch October 4, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants