-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check integration test results #4599
Conversation
|
size-limit report 📦
|
const { data } = await github.rest.repos.getBranch({ | ||
owner: 'github', | ||
repo: 'github', | ||
branch: BRANCH | ||
}); | ||
core.setOutput('branch', BRANCH); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of us calling out to the repo directly, do you think it would be possible for us to use repository dispatch to coordinate between github/github and primer/react? The advantage of this would be that we wouldn't need to have a token/app that has permissions to github/github in CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely possible! 👀 Hopefully we can make them as granular.
The advantage of this would be that we wouldn't need to have a token/app that has permissions to github/github in CI.
We would still need a token that can do the first repository dispatch to trigger primer-react-pr-test
workflow (not included in this PR). But, that would need significantly lower permissions which is better?
Integration PR has been created |
Context
I'd like to fetch and report the result of
golden-jobs-results
on the PR as a CI check and comment.Strategy 1: Pull (implemented here)
golden-jobs-results
has completed yetgolden-jobs-results
Strategy 2: Push (probably better!)
golden-jobs-results
has started/expectedgolden-jobs-results
has completed with results (based on label)Questions I need to think more about:
Rollout strategy