Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the CSS modules feature flag from the Link component #5019

Merged
merged 11 commits into from
Oct 7, 2024
Merged

Remove the CSS modules feature flag from the Link component #5019

merged 11 commits into from
Oct 7, 2024

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Sep 24, 2024 •
edited
Loading

Changelog

Removed

Remove the CSS modules feature flag from Link component

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 24, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: d92830c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Sep 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 24, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 96.7 KB (-0.23% 🔽)
packages/react/dist/browser.umd.js 97.02 KB (-0.15% 🔽)

@github-actions github-actions bot temporarily deployed to storybook-preview-5019 September 24, 2024 21:23 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5019 September 24, 2024 21:49 Inactive
@jonrohan jonrohan changed the title Remove feature flag from Link component Remove the CSS modules feature flag from the Link component Sep 24, 2024
@jonrohan jonrohan marked this pull request as ready for review September 24, 2024 22:06
@jonrohan jonrohan requested a review from a team as a code owner September 24, 2024 22:06
joshblack
joshblack approved these changes Sep 25, 2024
View reviewed changes
packages/react/src/Link/Link.module.css Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to storybook-preview-5019 September 26, 2024 22:11 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5019 October 2, 2024 17:39 Inactive
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/345286

@github-actions github-actions bot temporarily deployed to storybook-preview-5019 October 7, 2024 18:26 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5019 October 7, 2024 20:28 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5019 October 7, 2024 20:37 Inactive
@primer primer bot requested a review from a team as a code owner October 7, 2024 20:57
@primer primer bot requested a review from mperrotti October 7, 2024 20:57
@jonrohan jonrohan added this pull request to the merge queue Oct 7, 2024
Merged via the queue into main with commit c2f64aa Oct 7, 2024
32 checks passed
@jonrohan jonrohan deleted the css_modules_remove_feature_flag_link branch October 7, 2024 21:18
@primer primer bot mentioned this pull request Oct 7, 2024
Merged
jonrohan added a commit that referenced this pull request Oct 9, 2024
@jonrohan
Revert "Remove the CSS modules feature flag from the Link component (#…
5d9e140 
…5019)"

This reverts commit c2f64aa.
@jonrohan jonrohan mentioned this pull request Oct 9, 2024
Merged
13 tasks
github-merge-queue bot pushed a commit that referenced this pull request Oct 9, 2024
@jonrohan
Revert "Remove the CSS modules feature flag from the Link component (… (
a9d411c 
#5093)

* Revert "Remove the CSS modules feature flag from the Link component (#5019)"

This reverts commit c2f64aa.

* Remove featureFlags and redundant tests

* Fix story

* Remove import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

@mperrotti mperrotti Awaiting requested review from mperrotti mperrotti is a code owner automatically assigned from primer/design-reviewers

Assignees
No one assigned
Labels
staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonrohan @joshblack