Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs(ActionList): add role menu to actionlist inside overlay story #5030

Conversation

francinelucca
Copy link
Contributor

@francinelucca francinelucca commented Sep 25, 2024

Closes https://github.com/github/primer/issues/3476

Adds roles to ActionList/ActionList.Item overlay story to improve keyboard navigation experience on Windows.

Changelog

Changed

  • Adds role="menu" and role="menuitem" to ActionList/ActionList.Item components in ActionList Inside Overlay story.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Docs only update

Testing & Reviewing

tested by @TylerJDev on windows

Merge checklist

Copy link

changeset-bot bot commented Sep 25, 2024

⚠️ No Changeset found

Latest commit: f671579

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@francinelucca francinelucca added staff Author is a staff member skip changeset This change does not need a changelog labels Sep 25, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5030 September 25, 2024 20:19 Inactive
Copy link
Contributor

github-actions bot commented Sep 25, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 98.01 KB (0%)
packages/react/dist/browser.umd.js 98.32 KB (0%)

…navigation-broken-when-using-a-screen-reader
Copy link
Contributor

@TylerJDev TylerJDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@francinelucca francinelucca added this pull request to the merge queue Sep 27, 2024
Merged via the queue into main with commit 14b6506 Sep 27, 2024
38 checks passed
@francinelucca francinelucca deleted the 3476-prcactionlist-overlay-example-keyboard-navigation-broken-when-using-a-screen-reader branch September 27, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog staff Author is a staff member status: review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants