Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Banner: Fix margin for inline actions #5053

Merged
merged 4 commits into from
Oct 1, 2024
Merged

Banner: Fix margin for inline actions #5053

merged 4 commits into from
Oct 1, 2024

Conversation

siddharthkp
Copy link
Member

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 1, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: c1fb589

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Oct 1, 2024
@siddharthkp siddharthkp mentioned this pull request Oct 1, 2024
Closed
@siddharthkp siddharthkp changed the title we don't need margin when actions are inline Banner: Fix margin for inline actions Oct 1, 2024
@siddharthkp siddharthkp self-assigned this Oct 1, 2024
@siddharthkp siddharthkp marked this pull request as ready for review October 1, 2024 11:34
@siddharthkp siddharthkp requested a review from a team as a code owner October 1, 2024 11:34
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 96.74 KB (0%)
packages/react/dist/browser.umd.js 97.13 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-5053 October 1, 2024 11:36 Inactive
@primer primer bot requested a review from a team as a code owner October 1, 2024 11:44
@primer primer bot requested a review from mperrotti October 1, 2024 11:44
@github-actions github-actions bot temporarily deployed to storybook-preview-5053 October 1, 2024 11:46 Inactive
@siddharthkp siddharthkp added this pull request to the merge queue Oct 1, 2024
Merged via the queue into main with commit 2703d0c Oct 1, 2024
32 checks passed
@siddharthkp siddharthkp deleted the banner-fix-actions-alignment-with-dismissible branch October 1, 2024 16:45
@primer primer bot mentioned this pull request Oct 1, 2024
Merged
@primer primer bot mentioned this pull request Oct 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

@jonrohan jonrohan Awaiting requested review from jonrohan jonrohan is a code owner automatically assigned from primer/engineer-reviewers

@mperrotti mperrotti Awaiting requested review from mperrotti mperrotti is a code owner automatically assigned from primer/design-reviewers

Assignees

@siddharthkp siddharthkp

Labels
staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spacing is off when using Banner with hideTitle, actions, and dismiss button
2 participants
@siddharthkp @joshblack