Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create recommend-integration-tests.yml #5065

Merged
merged 40 commits into from
Oct 8, 2024

Conversation

siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Oct 4, 2024

If there are changes to packages/react/*, this workflow will post a comment recommending integration-tests and add a label (integration-tests:recommended) to the PR as well.

Exceptions: .stories.tsx|.docs.json

Will keep an eye on PRs and fine tune the list of exceptions as needed.

screenshot of comment by bot

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, workflow only change

@siddharthkp siddharthkp self-assigned this Oct 4, 2024

This comment was marked as resolved.

@github-actions github-actions bot added the staff Author is a staff member label Oct 4, 2024
Copy link
Contributor

github-actions bot commented Oct 4, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 96.74 KB (0%)
packages/react/dist/browser.umd.js 97.06 KB (0%)

@siddharthkp siddharthkp marked this pull request as ready for review October 7, 2024 09:36
@siddharthkp siddharthkp requested a review from a team as a code owner October 7, 2024 09:36
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/345802

@primer-integration
Copy link

🟢 golden-jobs completed with status success.

Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Just left a couple commoents/questions 👀

with:
node-version: 22

- name: Get source files changes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/dorny/paths-filter can be nice for this too as an alternative 👀

Copy link
Member Author

@siddharthkp siddharthkp Oct 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh this is going to be very helpful when we need to customise the message by path! Thanks!

.github/workflows/recommend-integration-tests.yml Outdated Show resolved Hide resolved
.github/workflows/recommend-integration-tests.yml Outdated Show resolved Hide resolved
issue_number: context.issue.number,
owner: context.repo.owner,
repo: context.repo.repo,
labels: ['integration-tests: recommended'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you want to go any further and do a status check? Maybe we could have a check on a PR that says that if integration-tests: recommended is present we must have integration-tests: passed applied as a label?

Copy link
Member Author

@siddharthkp siddharthkp Oct 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! That's in the plan 😈 (and with more automation)

Copy link
Contributor

github-actions bot commented Oct 8, 2024

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 8, 2024
@siddharthkp siddharthkp removed the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 8, 2024
@siddharthkp siddharthkp added this pull request to the merge queue Oct 8, 2024
Merged via the queue into main with commit f369706 Oct 8, 2024
43 checks passed
@siddharthkp siddharthkp deleted the workflow/recommend-integration-tests branch October 8, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants