-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create recommend-integration-tests.yml #5065
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
size-limit report 📦
|
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/345802 |
🟢 golden-jobs completed with status |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it! Just left a couple commoents/questions 👀
with: | ||
node-version: 22 | ||
|
||
- name: Get source files changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/dorny/paths-filter can be nice for this too as an alternative 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooh this is going to be very helpful when we need to customise the message by path! Thanks!
issue_number: context.issue.number, | ||
owner: context.repo.owner, | ||
repo: context.repo.repo, | ||
labels: ['integration-tests: recommended'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you want to go any further and do a status check? Maybe we could have a check on a PR that says that if integration-tests: recommended
is present we must have integration-tests: passed
applied as a label?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! That's in the plan 😈 (and with more automation)
Co-authored-by: Josh Black <joshblack@github.com>
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
If there are changes to
packages/react/*
, this workflow will post a comment recommending integration-tests and add a label (integration-tests:recommended
) to the PR as well.Exceptions:
.stories.tsx|.docs.json
Will keep an eye on PRs and fine tune the list of exceptions as needed.
Rollout strategy