Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try running vrt and aat on 16 core runners #5083

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Try running vrt and aat on 16 core runners #5083

merged 1 commit into from
Oct 8, 2024

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Oct 7, 2024 •
edited
Loading

We have ubuntu-latest-16-cores in primer, so I thought I'd give changing this a try. The jobs do seem faster, and we have 20 jobs we can run at a time. https://github.com/organizations/primer/settings/actions/github-hosted-runners/3?viewing_from_runner_group=false

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 7, 2024

⚠️ No Changeset found

Latest commit: caeccbf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Oct 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 96.7 KB (0%)
packages/react/dist/browser.umd.js 97.02 KB (0%)

@jonrohan jonrohan added the skip changeset This change does not need a changelog label Oct 7, 2024
@jonrohan jonrohan marked this pull request as ready for review October 7, 2024 23:17
@jonrohan jonrohan requested a review from a team as a code owner October 7, 2024 23:17
broccolinisoup
broccolinisoup approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✈️

joshblack
joshblack approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth a shot 🚀

@jonrohan jonrohan added this pull request to the merge queue Oct 8, 2024
Merged via the queue into main with commit 0a1f357 Oct 8, 2024
50 of 51 checks passed
@jonrohan jonrohan deleted the try_running_vrt_aat_16_cores branch October 8, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

@broccolinisoup broccolinisoup broccolinisoup approved these changes

@siddharthkp siddharthkp Awaiting requested review from siddharthkp siddharthkp is a code owner automatically assigned from primer/engineer-reviewers

Assignees
No one assigned
Labels
skip changeset This change does not need a changelog staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonrohan @broccolinisoup @joshblack