Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate BorderBox to TypeScript #973

Merged
merged 12 commits into from
Jan 26, 2021
Merged

Migrate BorderBox to TypeScript #973

merged 12 commits into from
Jan 26, 2021

Conversation

colebemis
Copy link
Contributor

This PR migrates the BorderBox component to TypeScript as part of the TypeScript refactor.

This PR also updates the @types/styled-components dependency and styled-components dev dependency because the previous versions were causing type errors.

@vercel
Copy link

vercel bot commented Jan 20, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-components/orvzle9gb
✅ Preview: https://primer-components-git-cb-ts-border-box.primer.now.sh

@colebemis colebemis mentioned this pull request Jan 20, 2021
53 tasks
@@ -46,7 +46,7 @@
"@styled-system/prop-types": "5.1.2",
"@styled-system/props": "5.1.4",
"@styled-system/theme-get": "5.1.2",
"@types/styled-components": "^4.4.0",
"@types/styled-components": "5.1.7",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make this a ^ version?

Copy link

@emplums emplums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but looks like some tests are failing, maybe due to the dependency changes?

@changeset-bot
Copy link

changeset-bot bot commented Jan 23, 2021

🦋 Changeset detected

Latest commit: 8c74234

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel vercel bot temporarily deployed to Preview January 23, 2021 00:26 Inactive
@vercel vercel bot temporarily deployed to Preview January 25, 2021 21:38 Inactive
@vercel vercel bot temporarily deployed to Preview January 25, 2021 21:42 Inactive
@colebemis
Copy link
Contributor Author

Ran into an issue updating the styled-components and jest-styled-components dev dependencies. The problem I ran into is documented in this issue: styled-components/jest-styled-components#294

I decided to leave those versions as-is and just update the @types/styled-components version. Is it worth trying to figure out the styled-components upgrade in this PR or is only updating the types package fine?

@vercel vercel bot temporarily deployed to Preview January 25, 2021 22:12 Inactive
@vercel vercel bot temporarily deployed to Preview January 25, 2021 22:22 Inactive
@vercel vercel bot temporarily deployed to Preview January 26, 2021 22:11 Inactive
@vercel vercel bot temporarily deployed to Preview January 26, 2021 22:23 Inactive
@colebemis colebemis merged commit 4b0d7b2 into main Jan 26, 2021
@github-actions github-actions bot mentioned this pull request Jan 26, 2021
@joshblack joshblack deleted the cb/ts-border-box branch January 19, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants