-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate BorderBox to TypeScript #973
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primer-components/orvzle9gb |
@@ -46,7 +46,7 @@ | |||
"@styled-system/prop-types": "5.1.2", | |||
"@styled-system/props": "5.1.4", | |||
"@styled-system/theme-get": "5.1.2", | |||
"@types/styled-components": "^4.4.0", | |||
"@types/styled-components": "5.1.7", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we make this a ^
version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but looks like some tests are failing, maybe due to the dependency changes?
🦋 Changeset detectedLatest commit: 8c74234 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Ran into an issue updating the I decided to leave those versions as-is and just update the |
This PR migrates the
BorderBox
component to TypeScript as part of the TypeScript refactor.This PR also updates the
@types/styled-components
dependency andstyled-components
dev dependency because the previous versions were causing type errors.