Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape on tooltip should not close underlying modal/menu #2410

Closed
bdmac opened this issue Nov 30, 2023 · 1 comment · Fixed by #2414
Closed

Escape on tooltip should not close underlying modal/menu #2410

bdmac opened this issue Nov 30, 2023 · 1 comment · Fixed by #2414
Labels

Comments

@bdmac
Copy link

bdmac commented Nov 30, 2023

Filing this per @keithamus request. In https://github.com/github/accessibility-audits/issues/5653 it is reported that pressing the escape key with focus on a tooltip should not close the underlying menu/modal. There was a bit of back and forth on that issue on what the correct behavior should be and also in this slack thread.

Here is the menu in question but I'm sure there are others where this applies.

Image

Copy link
Contributor

Uh oh! @bdmac, the image you shared is missing helpful alt text. Check your issue body.

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants
@bdmac and others