Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add natspec to let developers know NEVER to use this inside a non-view smart contract call #310

Closed
kinrezC opened this issue Jan 22, 2024 · 1 comment · Fixed by #318
Closed

Add natspec to let developers know NEVER to use this inside a non-view smart contract call #310

kinrezC opened this issue Jan 22, 2024 · 1 comment · Fixed by #318
Assignees
@clemlak
Labels
contracts Requiring smart contract changes
Milestone
DFMM going public

Comments

@kinrezC
Copy link
Contributor

kinrezC commented Jan 22, 2024

Add natspec to let developers know NEVER to use this inside a non-view smart contract call

Originally posted by @Alexangelj in #301 (comment)
@clemlak clemlak self-assigned this Jan 23, 2024
@clemlak clemlak added the contracts Requiring smart contract changes label Jan 23, 2024
@clemlak clemlak added this to the DFMM going public milestone Jan 23, 2024
@clemlak
Copy link
Contributor

clemlak commented Jan 23, 2024

This comment was referring to the function computing the amount of liquidity associated with an amount of LP tokens. This function is never used in the contract so it might make sense to simply remove it.

@clemlak clemlak mentioned this issue Jan 24, 2024
Merged
@clemlak clemlak linked a pull request Jan 24, 2024 that will close this issue
Clone factory & various fixes #318
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@clemlak clemlak

Labels
contracts Requiring smart contract changes
Projects
None yet
Milestone
DFMM going public
Development

Successfully merging a pull request may close this issue.

Clone factory & various fixes primitivefinance/mythic
2 participants
@kinrezC @clemlak