Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add completion for greek letters #242

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

Markos-Th09
Copy link
Contributor

Closes #157

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Files Coverage Δ
core/src/lib.rs 50.59% <0.00%> (-6.81%) ⬇️

📢 Thoughts on this report? Let us know!.

@printfn
Copy link
Owner

printfn commented Oct 26, 2023

This looks great! I’m not really seeing much benefit in adding the phf dependency though and would somewhat prefer keeping the code dependency-free if possible.

@Markos-Th09
Copy link
Contributor Author

This looks great! I’m not really seeing much benefit in adding the phf dependency though and would somewhat prefer keeping the code dependency-free if possible.

phf is generally preferred for this use case because a perfect hash map is what you need in this case

@printfn printfn merged commit b26977b into printfn:main Oct 30, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for greek letters insertion
2 participants