-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Docker support #40
Conversation
Hi, Would you be able to add the ability to add a versioned docker container when a new github release is created? I think that would be quite useful before merging? Chris |
@chriscpritchard the action defined in this PR builds a docker image on every push to the
|
Ah brill, I think I missed that! If you could rebase against master (once I've looked at and merged the URL queries one), I can look to merge! |
I rebased on master, will do again once #41 is merged. |
Hi, Sorry for the delay. I've merged #41 (there was a delay in shinyapps updating to the latest release of R so I couldn't test it). If you're happy to rebase I can test this branch out and then look to merge and create an updated release. Thank you for your contribution! Chris |
@chriscpritchard No worries at all. I am planning to work on this PR again this week, I will let you know once rebased. |
To probe the endpoint, request /healthz.txt from the container
@chriscpritchard now rebased on |
!deploy |
Really sorry about the delay with all this - work is extremely busy! I'll need to update our deployment workflow to use the latest version of the action and then I can test and push this. Hopefully I'll have some capacity over the weekend for this! |
Updated workflows so hopefully !deploy will work! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
This adds Docker support to simplify running the example shiny app.
No prerequisites are required except having Docker installed.
The
README.md
is also updated with build/run instructions.It also adds a new GitHub action to build and push the docker image to GitHub container registry.
This even simplifies running the shiny app further where users can simply pull the image instead of checking out the code and building it locally.