Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker support #40

Merged
merged 4 commits into from
Feb 3, 2023
Merged

Conversation

hammady
Copy link
Contributor

@hammady hammady commented Oct 20, 2022

This adds Docker support to simplify running the example shiny app.
No prerequisites are required except having Docker installed.
The README.md is also updated with build/run instructions.

It also adds a new GitHub action to build and push the docker image to GitHub container registry.
This even simplifies running the shiny app further where users can simply pull the image instead of checking out the code and building it locally.

@chriscpritchard
Copy link
Collaborator

Hi,

Would you be able to add the ability to add a versioned docker container when a new github release is created?

I think that would be quite useful before merging?

Chris

@chriscpritchard chriscpritchard self-assigned this Oct 29, 2022
@chriscpritchard chriscpritchard added the enhancement New feature or request label Oct 29, 2022
@hammady
Copy link
Contributor Author

hammady commented Oct 31, 2022

Would you be able to add the ability to add a versioned docker container when a new github release is created?

I think that would be quite useful before merging?

@chriscpritchard the action defined in this PR builds a docker image on every push to the master branch and tags it with the latest tag (docker tags). Moreover, any git tag that is pushed to that branch which starts with v, e.g. v1.2.3 also tags the generated image with the version number, e.g. 1.2.3. Please check this repo for examples. So basically:

git branch/tag docker tag
master latest
v1.2.3 1.2.3
Anything else No docker tag

@chriscpritchard
Copy link
Collaborator

chriscpritchard commented Oct 31, 2022

Ah brill, I think I missed that! If you could rebase against master (once I've looked at and merged the URL queries one), I can look to merge!

@hammady
Copy link
Contributor Author

hammady commented Oct 31, 2022

I rebased on master, will do again once #41 is merged.

@chriscpritchard
Copy link
Collaborator

Hi,

Sorry for the delay. I've merged #41 (there was a delay in shinyapps updating to the latest release of R so I couldn't test it).

If you're happy to rebase I can test this branch out and then look to merge and create an updated release.

Thank you for your contribution!

Chris

@hammady
Copy link
Contributor Author

hammady commented Nov 16, 2022

@chriscpritchard No worries at all. I am planning to work on this PR again this week, I will let you know once rebased.

@hammady
Copy link
Contributor Author

hammady commented Nov 24, 2022

@chriscpritchard now rebased on master.

@chriscpritchard
Copy link
Collaborator

!deploy

@chriscpritchard
Copy link
Collaborator

Really sorry about the delay with all this - work is extremely busy! I'll need to update our deployment workflow to use the latest version of the action and then I can test and push this. Hopefully I'll have some capacity over the weekend for this!

@chriscpritchard
Copy link
Collaborator

Updated workflows so hopefully !deploy will work!

Copy link
Collaborator

@chriscpritchard chriscpritchard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@chriscpritchard chriscpritchard merged commit 8cc5272 into prisma-flowdiagram:master Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants