-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tag/release on publishing #73
Comments
What to we want to name the tag? Started a WIP PR here #120 |
tag name = version name |
Do we want to tag both stable and unstable channel? If we just tag stable, we can use the version number yes.
Tags do have a message https://git-scm.com/book/en/v2/Git-Basics-Tagging It rendered like this (https://github.com/prisma/vscode/releases/tag/0.0.30) |
No, we need to tag all the commits properly to make it obvious as what version it got released.
We are not super interested in that as we do not have anything to show there. |
That limitation is a problem we need to fix then - add a prefix for example. |
So, in my PR, I did the following: Stable Extension version: Unstable Extension version: And in the message I include the linked Prisma version. |
Prisma version maybe? However, for older releases it might be misleading. |
Can you please also answer the third question from here #73 (comment) I think you missed it because I edited the comment as you were typing. |
I marked the PR ready for review. |
I would say that for the stable releases, we want a release where we can write release notes after release. |
When a new version is released, the commit should be tagged so we can understand what exactly got released and the releases are listed in the "Releases" tab.
The text was updated successfully, but these errors were encountered: