Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tag/release on publishing #73

Closed
janpio opened this issue Mar 25, 2020 · 10 comments · Fixed by #120
Closed

Add tag/release on publishing #73

janpio opened this issue Mar 25, 2020 · 10 comments · Fixed by #120
Assignees
Labels
kind/feature A request for a new feature. topic: automation
Milestone

Comments

@janpio
Copy link
Contributor

janpio commented Mar 25, 2020

When a new version is released, the commit should be tagged so we can understand what exactly got released and the releases are listed in the "Releases" tab.

@janpio janpio added kind/feature A request for a new feature. process/candidate Candidate for next Milestone. topic: automation labels Mar 25, 2020
@divyenduz divyenduz self-assigned this Apr 9, 2020
@divyenduz divyenduz added this to the Beta 3 milestone Apr 9, 2020
@divyenduz divyenduz added tech/typescript Issue for tech TypeScript. and removed process/candidate Candidate for next Milestone. labels Apr 9, 2020
@janpio janpio added team/other and removed tech/typescript Issue for tech TypeScript. labels Apr 11, 2020
@janpio janpio modified the milestones: Beta 3, Beta 4 Apr 21, 2020
@divyenduz
Copy link

divyenduz commented Apr 28, 2020

What to we want to name the tag?
What content do we want the tag message to have?
Do we need a release linked to a tag or just an annotated tag (which is also rendered by Github release page), example,

image

Started a WIP PR here #120

@janpio
Copy link
Contributor Author

janpio commented Apr 28, 2020

tag name = version name
tag message = tags do not have a message

@divyenduz
Copy link

divyenduz commented Apr 28, 2020

tag name = version name

Do we want to tag both stable and unstable channel? If we just tag stable, we can use the version number yes.

tag message = tags do not have a message

Tags do have a message https://git-scm.com/book/en/v2/Git-Basics-Tagging

It rendered like this (https://github.com/prisma/vscode/releases/tag/0.0.30)

image

@janpio
Copy link
Contributor Author

janpio commented Apr 28, 2020

Do we want to tag both stable and unstable channel? If we just tag stable, we can use the version number yes.

No, we need to tag all the commits properly to make it obvious as what version it got released.

Annotated tags do have a message https://git-scm.com/book/en/v2/Git-Basics-Tagging

We are not super interested in that as we do not have anything to show there.
In theory we could add a link to the VSCode Marketplace there.

@janpio
Copy link
Contributor Author

janpio commented Apr 28, 2020

If we just tag stable, we can use the version number yes.

That limitation is a problem we need to fix then - add a prefix for example.

@divyenduz
Copy link

divyenduz commented Apr 28, 2020

So, in my PR, I did the following:

Stable

Extension version: 0.0.33
Tag: v0.0.33

Unstable

Extension version: 0.0.7
Tag: v0.0.7-dev

And in the message I include the linked Prisma version.

@divyenduz
Copy link

We are not super interested in that as we do not have anything to show there.
In theory we could add a link to the VSCode Marketplace there.

Prisma version maybe?
I don't think Marketplace link can be tied to a version but we can add the link to the extension in the marketplace in general.

However, for older releases it might be misleading.

@divyenduz
Copy link

Can you please also answer the third question from here #73 (comment)

I think you missed it because I edited the comment as you were typing.

@divyenduz
Copy link

I marked the PR ready for review.

@janpio
Copy link
Contributor Author

janpio commented Apr 28, 2020

Do we need a release linked to a tag or just an annotated tag (which is also rendered by Github release page), example,

I would say that for the stable releases, we want a release where we can write release notes after release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature A request for a new feature. topic: automation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants