Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement(CI): clean build before publish #262

Merged
merged 1 commit into from
Jun 22, 2020
Merged

improvement(CI): clean build before publish #262

merged 1 commit into from
Jun 22, 2020

Conversation

carmenberndt
Copy link
Contributor

@carmenberndt carmenberndt commented Jun 22, 2020 •
edited
Loading

closes #252

divyenduz
divyenduz approved these changes Jun 22, 2020
View reviewed changes
Copy link

@divyenduz divyenduz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this works all the time great. I have seen some other repositories to rm -rf out folder. Maybe you can look up why that is necessary sometimes.

From my end, this is approved otherwise.

@carmenberndt
Copy link
Contributor Author

If this works all the time great. I have seen some other repositories to rm -rf out folder. Maybe you can look up why that is necessary sometimes.

Yes, the --clean flag is part of project-references and works only with it. In projects without references, rm -rf out is necessary.

@carmenberndt carmenberndt added this to the 2.1.0 milestone Jun 22, 2020
@carmenberndt carmenberndt merged commit 3b9d0e4 into master Jun 22, 2020
@carmenberndt carmenberndt deleted the improv_cleanBuildBeforePublish branch June 22, 2020 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyenduz divyenduz divyenduz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

Clean build before publish
2 participants
@carmenberndt @divyenduz