Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

[Suggestion] Rename Migrate Commands #162

Closed
johannesschobel opened this issue Oct 8, 2019 · 2 comments
Closed

[Suggestion] Rename Migrate Commands #162

johannesschobel opened this issue Oct 8, 2019 · 2 comments
Assignees
Labels

Comments

@johannesschobel
Copy link

johannesschobel commented Oct 8, 2019

Dear Prisma Team,

recently I came up with the suggestion to rename the Lift commands. In this context I propose the following changes:

prisma migrate save    --> prisma migrate commit
prisma migrate up      --> prisma migrate push
prisma migrate down    --> prisma migrate revert

This would make the commands more "git like" and (maybe) more memorable.

This would also reflect the fact, that a save is only a local change (same as with git commit) and in order to make this "commit" available, you need to push it to the database.

The downside with this is, that - if you're a heavy git cli user - you may get confused with the similar commands 😕

Maybe it is also possible to have some kind of "aliases" for these commands? I am currently using custom npm commands in my package.json to alias those commands. For example, I'm using db:commit instead of prisma2 lift save and db:push for prisma2 lift up. Its shorter as well 😃

What are your opinions on this?
All the best

@janpio janpio self-assigned this Oct 8, 2019
@janpio janpio transferred this issue from prisma/prisma Oct 8, 2019
@janpio
Copy link
Contributor

janpio commented Oct 8, 2019

(I moved this into prisma/lift as it concerns functionality of that project)

Thanks for the suggestions here @johannesschobel, I am currently looking deep into what Lift does and why, and the names of the commands came up a few times during that already. But I also know there is quite a bit of history, so I will keep on gathering information and then report back.

@janpio janpio added the kind/discussion Discussion is required. label Oct 8, 2019
@janpio janpio changed the title [Suggestion] Rename Lift Commands [Suggestion] Rename Migrate Commands Apr 27, 2020
@albertoperdomo
Copy link
Contributor

Thanks. We are reviewing all the commands for migrate, currently.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants